Re: [PATCH 4/5] wined3d: refactoring and add Mesa AMD/ATI driver support

[Henri Verbeet]

On 26 February 2010 06:39, Paul-Andre Panon <ppanon(a)shaw.ca> wrote:
> +enum wined3d_pci_device (select_card_nvidia_binary)(const struct wined3d_gl_info *gl_info, const char *gl_renderer,
> +            unsigned int *vidmem )
> +{
>              /* Both the GeforceFX, 6xxx and 7xxx series support D3D9. The last two types have more

I'm not sure why you have the braces around the function name, but
they should be superfluous. I guess you kept the indentation like that
to reduce the size of the diff, but I think it's better to just change
it.
> +		 continue;
> You have some stray tabs here.
> +    /* Default to generic Nvidia hardware based on the supported OpenGL extensions. The choice
> +     * for Nvidia was because the hardware and drivers they make are of good quality. This makes
> +     * them a good generic choice. */
> You'll probably want to print a FIXME or WARN if we get here, since it
> means the card wasn't recognized.

Overall the patches look pretty reasonable, the issues I mentioned are
all minor. You should use more descriptive subjects for your patches
though, these end up in the commit log, and "wined3d: refactoring and
add Mesa AMD/ATI driver support" doesn't say much about what the
individual patches are supposed to do.