WineTest regressions

[Francois Gouget]

It looks like this patch caused two regressions:

commit c8f338369695d360e021f2cbd82a18b2c0eb1514
Author: Alexandre Julliard <julliard(a)winehq.org>
Date:   Tue Dec 17 15:54:38 2019 +0100

    include: Allow using debug.h in tests.
    
    Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>


* https://test.winehq.org/data/tests/kernel32:codepage.html
  Something between line 333 and 336 modifies LastError, setting it to 
  ERROR_PROC_NOT_FOUND. Probably the call to wine_dbgstr_wn().

* https://test.winehq.org/data/tests/psapi:psapi_main.html
  Same thing between line 680 and 684 but this time the suspect 
  is wine_dbgstr_w().

I see two options for fixing:
* Modifying wine_dbgstr_*() so they don't modify LastError.
  If that's possible.

* Test LastError before it has been modified (or store it for testing 
  later). That would probably be good policy regardless.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                  Hell is empty and all the devils are here.
                       -- Wm. Shakespeare, "The Tempest"

[Alexandre Julliard]

Francois Gouget <fgouget(a)free.fr> writes:
> I see two options for fixing:
> * Modifying wine_dbgstr_*() so they don't modify LastError.
>   If that's possible.

It should be fixed by a812374a529f553da0f4c0b9c2d67b9178f644ff.

-- 
Alexandre Julliard
julliard(a)codeweavers.com