Re: msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)
On 08/10/14 10:32, YongHao Hu wrote:
+complex_float* __cdecl complex_float_pow_ci(complex_float *ret, const complex_float *l, int r) +{ + complex_float c = *l; + complex_float temp = { 1.0, 0 }; + complex_float_assign(ret, &temp); + + if(r < 0){ + r = -r; + complex_float_div(&c, &temp, l); + } + + for(; r>0; r>>=1) + { + if( (r%2)&1 ) Please fix the if condition. You're also using tabs in the patch, please use spaces instead.
Thanks, Piotr
Thank you for your comment. + if(r%2 & 1) How do you think of this if condition now? On Thursday, August 14, 2014 09:45 PM, Piotr Caban wrote:
On 08/10/14 10:32, YongHao Hu wrote:
+complex_float* __cdecl complex_float_pow_ci(complex_float *ret, const complex_float *l, int r) +{ + complex_float c = *l; + complex_float temp = { 1.0, 0 }; + complex_float_assign(ret, &temp); + + if(r < 0){ + r = -r; + complex_float_div(&c, &temp, l); + } + + for(; r>0; r>>=1) + { + if( (r%2)&1 ) Please fix the if condition. You're also using tabs in the patch, please use spaces instead.
Thanks, Piotr
Oh, I have ignored this. -_- Is there any problem in this patch now? ------------------ 原始邮件 ------------------ 发件人: "Piotr Caban"<piotr(a)codeweavers.com>; 发送时间: 2014年8月15日(星期五) 下午5:57 收件人: "胡子浩"<christopherwuy(a)gmail.com>; "wine-devel"<wine-devel(a)winehq.org>; 主题: Re: msvcp90: Added complex_float_pow impletation(Fix precision) andtests(Try 3) On 08/15/14 11:49, YongHao Hu wrote:
+ if(r%2 & 1)
How do you think of this if condition now? It makes the same thing as if(r&1).
participants (3)
-
Piotr Caban -
XX浩夢葉 -
YongHao Hu