Re: [1/3]msctf: ThreadMgr sink framework

[Alexandre Julliard]

Aric Stewart <aric(a)codeweavers.com> writes:
> typedef struct tagACLMulti {
>      const ITfThreadMgrVtbl *ThreadMgrVtbl;
>      const ITfSourceVtbl *SourceVtbl;
>      LONG refCount;
>
> ITfDocumentMgr *focus;
> +
> +    /* kept as separate lists to reduce unnecessary iterations */
> +    struct list     pActiveLanguageProfileNotifySink;
> +    struct list     pDisplayAttributeNotifySink;
> +    struct list     pKeyTraceEventSink;
> +    struct list     pPreservedKeyNotifySink;
> +    struct list     pThreadFocusSink;
> +    struct list     pThreadMgrEventSink;

Please pick better names for your variables. Hungarian notation is not a
good idea in general, but incorrect Hungarian prefixes are even worse,
these are not pointers.

-- 
Alexandre Julliard
julliard(a)winehq.org

[1/3]msctf: ThreadMgr sink framework

[Aric Stewart]

Thanks, resent.

-aric

Alexandre Julliard wrote:
> Aric Stewart <aric(a)codeweavers.com> writes:
> > typedef struct tagACLMulti {
> >      const ITfThreadMgrVtbl *ThreadMgrVtbl;
> >      const ITfSourceVtbl *SourceVtbl;
> >      LONG refCount;
> >
> > ITfDocumentMgr *focus;
> > +
> > +    /* kept as separate lists to reduce unnecessary iterations */
> > +    struct list     pActiveLanguageProfileNotifySink;
> > +    struct list     pDisplayAttributeNotifySink;
> > +    struct list     pKeyTraceEventSink;
> > +    struct list     pPreservedKeyNotifySink;
> > +    struct list     pThreadFocusSink;
> > +    struct list     pThreadMgrEventSink;
>
> Please pick better names for your variables. Hungarian notation is not a
> good idea in general, but incorrect Hungarian prefixes are even worse,
> these are not pointers.