Re: [PATCH 1/2 v6] ntdll/socket: Implement exclusive flag for IOCTL_AFD_POLL.

[Guillaume Charifi-Hoareau]

I'm a bit confused, how the code is supposed to work if the generated files that are part of the repository are not committed?

Le 3 sept. 2021 09:05, Dmitry Timoshkov <dmitry(a)baikal.ru> a écrit :
> Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote:
> > --- a/server/sock.c 
> > +++ b/server/sock.c 
> > @@ -128,12 +128,14 @@ struct poll_req 
> >       struct async *async; 
> >       struct iosb *iosb; 
> >       struct timeout_user *timeout; 
> > +    char exclusive;
>
> This one should probably be 'int' as well. Also, the size of the patch 
> could be reduced by avoiding generated parts.
>
> -- 
> Dmitry.

[PATCH 1/2 v6] ntdll/socket: Implement exclusive flag for IOCTL_AFD_POLL.

[Dmitry Timoshkov]

Guillaume Charifi-Hoareau <guillaume.charifi(a)sfr.fr> wrote:
> I'm a bit confused, how the code is supposed to work if the generated files
> that are part of the repository are not committed?

The files are generated by the maintainer during committing a patch.

-- 
Dmitry.