Re: setupapi: Add stub for SetupInstallServicesFromInfSectionW

[Robert Shearman]

Chris Robinson wrote:
> @ stdcall SetupInstallFromInfSectionA(long long str long long str long ptr ptr long ptr)
>  @ stdcall SetupInstallFromInfSectionW(long long wstr long long wstr long ptr ptr long ptr)
>  @ stdcall SetupInstallServicesFromInfSectionA(long str long)
> +@ stdcall SetupInstallServicesFromInfSectionW(long wstr long)
>  @ stub SetupInstallServicesFromInfSectionExA
>  @ stub SetupInstallServicesFromInfSectionExW
> -@ stub SetupInstallServicesFromInfSectionW
>  @ stdcall SetupIterateCabinetA(str long ptr ptr)
>  @ stdcall SetupIterateCabinetW(wstr long ptr ptr)
>  @ stub SetupLogErrorA

There's no need to move the entry for 
SetupInstallServicesFromInfSectionW. The list was sorted alphabetically, 
but now it isn't.

-- 
Rob Shearman

setupapi: Add stub for SetupInstallServicesFromInfSectionW

[Frank Richter]

On 01.11.2007 14:26, Robert Shearman wrote:
> There's no need to move the entry for 
> SetupInstallServicesFromInfSectionW. The list was sorted alphabetically, 
> but now it isn't.

Unless you ignore the A/W suffix. One could argue that this is more
intuitive as you could locate an entry in the list by searching for the
undecorated name and then look for the one with the appropriate suffix,
which is at most one line away. If you sort strictly alphabetically, A/W
variants may be a couple of lines away (e.g. FooA/FooExA/FooExW/FooW)
which could make finding the right variant slightly counterintuitive.

-f.r.

setupapi: Add stub for SetupInstallServicesFromInfSectionW

[Alexandre Julliard]

Frank Richter <frank.richter(a)gmail.com> writes:
> Unless you ignore the A/W suffix. One could argue that this is more
> intuitive as you could locate an entry in the list by searching for the
> undecorated name and then look for the one with the appropriate suffix,
> which is at most one line away. If you sort strictly alphabetically, A/W
> variants may be a couple of lines away (e.g. FooA/FooExA/FooExW/FooW)
> which could make finding the right variant slightly counterintuitive.

It may be counterintuitive, but it is sorted alphabetically on Windows
so we want to do it the same way.

-- 
Alexandre Julliard
julliard(a)winehq.org