Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

[Rob Shearman]

2009/1/6 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> Hi,
>
> For some reason this only shows up when I use my own cross compiled tests.
>
> Changelog
>  ILFree() is only exported by ordinal on Win9x

ILFree is exported using -noname in Wine, so it should be imported by
ordinal. You need to investigate further as to why it isn't working
for you. I suggest to start by running "winedump dump -j import
shell32_crosstest.exe".

-- 
Rob Shearman

[shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

[Alexandre Julliard]

"Rob Shearman" <robertshearman(a)gmail.com> writes:
> 2009/1/6 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> > Hi,
> >
> > For some reason this only shows up when I use my own cross compiled tests.
> >
> > Changelog
> >  ILFree() is only exported by ordinal on Win9x
>
> ILFree is exported using -noname in Wine, so it should be imported by
> ordinal. You need to investigate further as to why it isn't working
> for you. I suggest to start by running "winedump dump -j import
> shell32_crosstest.exe".

Most likely it was built against the Mingw import libs, they don't use
ordinal imports. That's a Mingw bug.

-- 
Alexandre Julliard
julliard(a)winehq.org

[shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

[Paul Vriens]

Alexandre Julliard wrote:
> "Rob Shearman" <robertshearman(a)gmail.com> writes:
> > 2009/1/6 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> > > Hi,
> > >
> > > For some reason this only shows up when I use my own cross compiled tests.
> > >
> > > Changelog
> > >  ILFree() is only exported by ordinal on Win9x
> > > ILFree is exported using -noname in Wine, so it should be imported by
> > > ordinal. You need to investigate further as to why it isn't working
> > > for you. I suggest to start by running "winedump dump -j import
> > > shell32_crosstest.exe".
>
> Most likely it was built against the Mingw import libs, they don't use
> ordinal imports. That's a Mingw bug.

Yeah, that's probably it as I cross compiled in the tests directory and not on 
the highest level.

-- 
Cheers,

Paul.

[shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

[Paul Vriens]

Rob Shearman wrote:
> 2009/1/6 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> > Hi,
> >
> > For some reason this only shows up when I use my own cross compiled tests.
> >
> > Changelog
> >  ILFree() is only exported by ordinal on Win9x
>
> ILFree is exported using -noname in Wine, so it should be imported by
> ordinal. You need to investigate further as to why it isn't working
> for you. I suggest to start by running "winedump dump -j import
> shell32_crosstest.exe".

All other uses of ILFree() in the shell32 tests do it the same way. So the fact 
that I need this should be ok. The only strange thing is that I get an error 
when running the unpatched version of the cross compiled test on win9x.

Unpatched gives me:

[paul(a)penguin tests]$ winedump dump -j import shell32_crosstest.exe | grep Free
    479  HeapFree 4aa04
    534  LocalFree 4aa28
     37  ILFree 4ae18
    106  DdeFreeDataHandle 4af38
    107  DdeFreeStringHandle 4af4c

Patched (of course):

[paul(a)penguin tests]$ winedump dump -j import shell32_crosstest.exe | grep Free
    479  HeapFree 4a9fc
    534  LocalFree 4aa20
    106  DdeFreeDataHandle 4af26
    107  DdeFreeStringHandle 4af3a

-- 
Cheers,

Paul.