[PATCH] winetest/dissect: Stop complaining if a test file doesn't match the current test.
Now that we have support for custom dlls in e.g. dlls/msi/tests/custom.c. --- winetest/dissect | 2 -- 1 file changed, 2 deletions(-) diff --git a/winetest/dissect b/winetest/dissect index 9635f0a..7416317 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -624,7 +624,6 @@ while ($line = <IN>) { add_test_line("failed", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "failure"); $failures++; } elsif ($line =~ /^()([_a-z0-9]+)\.c:(\d+): (Test marked todo: .*)$/ or @@ -635,7 +634,6 @@ while ($line = <IN>) { add_test_line("todo", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "todo"); $todo++; } elsif ($line =~ /^()([_a-z0-9]+)\.c:(\d+): (Tests skipped: .*)$/ or -- 2.7.4
Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> On 27/02/18 09:56, Zebediah Figura wrote:
Now that we have support for custom dlls in e.g. dlls/msi/tests/custom.c. --- winetest/dissect | 2 -- 1 file changed, 2 deletions(-)
diff --git a/winetest/dissect b/winetest/dissect index 9635f0a..7416317 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -624,7 +624,6 @@ while ($line = <IN>) { add_test_line("failed", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "failure"); $failures++; } elsif ($line =~ /^()([_a-z0-9]+)\.c:(\d+): (Test marked todo: .*)$/ or @@ -635,7 +634,6 @@ while ($line = <IN>) { add_test_line("todo", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "todo"); $todo++; } elsif ($line =~ /^()([_a-z0-9]+)\.c:(\d+): (Tests skipped: .*)$/ or
On Tue, 27 Feb 2018, Zebediah Figura wrote:
Now that we have support for custom dlls in e.g. dlls/msi/tests/custom.c. [...] add_test_line("failed", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "failure"); [...] add_test_line("todo", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "todo");
Note that with these two chunks check_unit() would be unused so it should be removed (and maybe some infrastructure for it too). But then I'd prefer to preserve the check somehow. However I don't see a case where this patch is needed so far. Maybe I missed something? -- Francois Gouget <fgouget(a)codeweavers.com>
On 07/03/18 06:26, Francois Gouget wrote:
On Tue, 27 Feb 2018, Zebediah Figura wrote:
Now that we have support for custom dlls in e.g. dlls/msi/tests/custom.c. [...] add_test_line("failed", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "failure"); [...] add_test_line("todo", escapeHTML($pollution) . get_source_link($l_unit, $l_num) .": ". escapeHTML($l_text)); - check_unit($l_unit, "todo");
Note that with these two chunks check_unit() would be unused so it should be removed (and maybe some infrastructure for it too). But then I'd prefer to preserve the check somehow.
However I don't see a case where this patch is needed so far. Maybe I missed something?
It's for msi:install: http://test.winehq.org/data/7b62a970e9ad3b4179394cf54f0232475fe2388a/linux_c...
participants (2)
-
Francois Gouget -
Zebediah Figura