Re: [PATCH 6/6] ddraw: Replace wined3d_surface_preload() with wined3d_texture_preload().
On 31 January 2016 at 11:22, Riccardo Bortolato <rikyz619(a)gmail.com> wrote:
Also removed wined3d_surface_preload as it's now unused
Signed-off-by: Riccardo Bortolato <rikyz619(a)gmail.com> --- dlls/ddraw/device.c | 2 +- dlls/wined3d/surface.c | 13 ------------- dlls/wined3d/wined3d.spec | 1 - include/wine/wined3d.h | 1 - 4 files changed, 1 insertion(+), 16 deletions(-)
You may have noticed that I started working on this myself instead, and this patch is practically a duplicate of 118671.
Il 01/feb/2016 15:23, "Henri Verbeet" <hverbeet(a)gmail.com> ha scritto:
On 31 January 2016 at 11:22, Riccardo Bortolato <rikyz619(a)gmail.com> wrote:
Also removed wined3d_surface_preload as it's now unused
Signed-off-by: Riccardo Bortolato <rikyz619(a)gmail.com> --- dlls/ddraw/device.c | 2 +- dlls/wined3d/surface.c | 13 ------------- dlls/wined3d/wined3d.spec | 1 - include/wine/wined3d.h | 1 - 4 files changed, 1 insertion(+), 16 deletions(-)
You may have noticed that I started working on this myself instead, and this patch is practically a duplicate of 118671.
Yes, I noticed on wine-patches after rebasing and sending my set, the rest is still appliable though. I also have sitting in my queue since months a patch identical to 118671, but if linking my github repository isn't enough I don't know how to signal those changes to the wine community (in order to avoid duplication of work). I don't want to spam wine-devel too much, should I post that list to you privately? Or you mean you will work on this cleanup and I should just stop posting them? Ciao, Riccardo
On 1 February 2016 at 15:47, Riccardo Bortolato <rikyz619(a)gmail.com> wrote:
Yes, I noticed on wine-patches after rebasing and sending my set, the rest is still appliable though. I also have sitting in my queue since months a patch identical to 118671, but if linking my github repository isn't enough I don't know how to signal those changes to the wine community (in order to avoid duplication of work).
I don't think the github interface is all that practical for reviewing patches, although I'm sure that's just personal prejudice. The contents of github repositories also have a tendency to change. Either way, the result is that I rarely look at github links. If you want me to actually look at a series, do something along the lines of "git format-patch --stdout origin | xz > patches.mbox.xz", and attach it to a mail to wine-devel.
I don't want to spam wine-devel too much, should I post that list to you privately? Or you mean you will work on this cleanup and I should just stop posting them?
But yeah, at this point I've pretty much started working on it myself, and at least the next 20 or so patches in my tree aren't all that tricky, so it's probably best to just wait a while until I'm done.
2016-02-01 16:03 GMT+01:00 Henri Verbeet <hverbeet(a)gmail.com>:
On 1 February 2016 at 15:47, Riccardo Bortolato <rikyz619(a)gmail.com> wrote:
Yes, I noticed on wine-patches after rebasing and sending my set, the rest is still appliable though. I also have sitting in my queue since months a patch identical to 118671, but if linking my github repository isn't enough I don't know how to signal those changes to the wine community (in order to avoid duplication of work).
I don't think the github interface is all that practical for reviewing patches, although I'm sure that's just personal prejudice. The contents of github repositories also have a tendency to change. Either way, the result is that I rarely look at github links. If you want me to actually look at a series, do something along the lines of "git format-patch --stdout origin | xz > patches.mbox.xz", and attach it to a mail to wine-devel.
OK.
I don't want to spam wine-devel too much, should I post that list to you privately? Or you mean you will work on this cleanup and I should just stop posting them?
But yeah, at this point I've pretty much started working on it myself, and at least the next 20 or so patches in my tree aren't all that tricky, so it's probably best to just wait a while until I'm done.
Fine, would you mind sharing your queue then? I have currently more than 40 patches that I'm constantly rebasing, it would help knowing it's not a pointless exercise. Thanks, Riccardo
participants (2)
-
Henri Verbeet -
Riccardo Bortolato