Re: Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

[Michael Stefaniuc]

Hello Jacek,

Smatch complains about unreachable code introduced by this patch:

Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 536fac7c1b4ef7f6f124d7f3100d3284313f3018
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=536fac7c1b4ef7f6f124d7f310...
>
> Author: Jacek Caban <jacek(a)codeweavers.com>
> Date:   Tue Oct  7 14:44:18 2008 -0500
>
> mshtml: Added IHTMLElement3 stub implementation.
>
> ---
>
> dlls/mshtml/Makefile.in      |    1 +
>  dlls/mshtml/htmlelem.c       |    4 +
>  dlls/mshtml/htmlelem3.c      |  447 ++++++++++++++++++++++++++++++++++++++++++
>  dlls/mshtml/mshtml_private.h |    3 +
>  dlls/mshtml/tests/dom.c      |   14 ++
>  5 files changed, 469 insertions(+), 0 deletions(-)
>
> Diff:   http://source.winehq.org/git/wine.git/?a=commitdiff;h=536fac7c1b4ef7f6f124d7...

diff --git a/dlls/mshtml/htmlelem3.c b/dlls/mshtml/htmlelem3.c
new file mode 100644
index 0000000..f85b065
--- /dev/null
+++ b/dlls/mshtml/htmlelem3.c
...
+
+static HRESULT WINAPI HTMLElement3_put_disabled(IHTMLElement3 *iface, 
VARIANT_B
+{
+    HTMLElement *This = HTMLELEM3_THIS(iface);
+    FIXME("(%p)->(%x)\n", This, v);
+    return S_OK;
+    return E_NOTIMPL;
+}
+
...

I would say to remove the S_OK return but I really don't know what is 
the best here.

thanks
bye
	michael

Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

[Jacek Caban]

Michael Stefaniuc wrote:
> I would say to remove the S_OK return but I really don't know what is 
> the best here.

Thanks, I that's my temporary hack that I've missed then I was preparing 
the patch. I will send put_disable implementation in next series of 
patches. Otherwise I'd have to resend the whole series as patchwatcher 
doesn't like partial resends and I don't want to spam the list.


Thanks,
    Jacek

Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.

[Jacek Caban]

Ops, sorry, you were not commenting my today patch. There's too much of 
them lately... Anyway, I will send a fix tomorrow.

Jacek