Re: Allow to display all builtin Wine video codecs in ICCompressorChoose

[Andreas Mohr]

Hi,

On Thu, Nov 24, 2005 at 10:21:26PM +0800, Dmitry Timoshkov wrote:
> +    icinfo->dwVersion = 0x00010000; /* Version 1.0 build 0 */
> +    icinfo->dwVersionICM = 0x01040000; /* Version 1.4 build 0 */

This doesn't really add up.
If it made complete sense, Version 1.0 build 0 would be 0x01000000.
But then I assume this conflict is for real, no? (we all know why we love MS,
no?)

Andreas

Allow to display all builtin Wine video codecs inICCompressorChoose

[Dmitry Timoshkov]

"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote:
> On Thu, Nov 24, 2005 at 10:21:26PM +0800, Dmitry Timoshkov wrote:
> > +    icinfo->dwVersion = 0x00010000; /* Version 1.0 build 0 */
> > +    icinfo->dwVersionICM = 0x01040000; /* Version 1.4 build 0 */
>
> This doesn't really add up.
> If it made complete sense, Version 1.0 build 0 would be 0x01000000.
> But then I assume this conflict is for real, no? (we all know why we love MS,
> no?)

I didn't really test what Windows returns in that fileds, just copied
what msrle32 has. If you feel brave enough to test and make a patch go
ahead.

-- 
Dmitry.

Allow to display all builtin Wine video codecs inICCompressorChoose

[Andreas Mohr]

Hi,

On Thu, Nov 24, 2005 at 11:29:04PM +0800, Dmitry Timoshkov wrote:
> "Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote:
> > On Thu, Nov 24, 2005 at 10:21:26PM +0800, Dmitry Timoshkov wrote:
> > > +    icinfo->dwVersion = 0x00010000; /* Version 1.0 build 0 */
> > > +    icinfo->dwVersionICM = 0x01040000; /* Version 1.4 build 0 */
> >
> > This doesn't really add up.
> > If it made complete sense, Version 1.0 build 0 would be 0x01000000.
> > But then I assume this conflict is for real, no? (we all know why we love MS,
> > no?)
>
> I didn't really test what Windows returns in that fileds, just copied
> what msrle32 has. If you feel brave enough to test and make a patch go
> ahead.

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/multimed/ht...
says dwVersionICM should be set to ICVERSION, and Google says ICVERSION is
defined as 0x0104, and other internet pages directly assign a 0x0104 value.

dwVersion appears to be endianness swapped, too:
I've seen 0 and 0x00020001 used several times.

Andreas