[PATCH v2 1/2] reg: Parse 'reg query' command-line arguments in query.c

[Hugh McMaster]

Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com>
---
v2: Fix incorrect variable name causing apply failure.
 programs/reg/query.c | 51 +++++++++++++++++++++++++++++++++++++++++++-
 programs/reg/reg.c   | 16 ++++++--------
 programs/reg/reg.h   |  3 +--
 3 files changed, 57 insertions(+), 13 deletions(-)

diff --git a/programs/reg/query.c b/programs/reg/query.c
index 6ab518c91d9..7ae99fad6d5 100644
--- a/programs/reg/query.c
+++ b/programs/reg/query.c
@@ -298,7 +298,7 @@ static int query_all(HKEY key, WCHAR *path, BOOL recurse)
     return 0;
 }
 
-int reg_query(HKEY root, WCHAR *path, WCHAR *key_name, WCHAR *value_name,
+static int run_query(HKEY root, WCHAR *path, WCHAR *key_name, WCHAR *value_name,
               BOOL value_empty, BOOL recurse)
 {
     HKEY key;
@@ -325,3 +325,52 @@ int reg_query(HKEY root, WCHAR *path, WCHAR *key_name, WCHAR *value_name,
 
     return ret;
 }
+
+int reg_query(int argc, WCHAR *argvW[])
+{
+    HKEY root;
+    WCHAR *path, *key_name, *value_name = NULL;
+    BOOL value_empty = FALSE, recurse = FALSE;
+    int i;
+
+    if (!parse_registry_key(argvW[2], &root, &path, &key_name))
+        return 1;
+
+    for (i = 3; i < argc; i++)
+    {
+        if (argvW[i][0] == '/' || argvW[i][0] == '-')
+        {
+            WCHAR *str = &argvW[i][1];
+
+            if (!lstrcmpiW(str, L"ve"))
+            {
+                value_empty = TRUE;
+                continue;
+            }
+            else if (!str[0] || str[1])
+                goto invalid;
+
+            switch (towlower(*str))
+            {
+            case 'v':
+                if (value_name || !(value_name = argvW[++i]))
+                    goto invalid;
+                break;
+            case 's':
+                recurse = TRUE;
+                break;
+            default:
+                goto invalid;
+            }
+        }
+    }
+
+    if (value_name && value_empty)
+        goto invalid;
+
+    return run_query(root, path, key_name, value_name, value_empty, recurse);
+
+invalid:
+    output_message(STRING_INVALID_CMDLINE);
+    return 1;
+}
diff --git a/programs/reg/reg.c b/programs/reg/reg.c
index 53f87e1defa..88889205ca7 100644
--- a/programs/reg/reg.c
+++ b/programs/reg/reg.c
@@ -337,7 +337,7 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
     static const WCHAR switchVAW[] = {'v','a',0};
     static const WCHAR switchVEW[] = {'v','e',0};
     WCHAR *key_name, *path, *value_name = NULL, *type = NULL, *data = NULL, separator = '\0';
-    BOOL value_empty = FALSE, value_all = FALSE, recurse = FALSE, force = FALSE;
+    BOOL value_empty = FALSE, value_all = FALSE, force = FALSE;
     HKEY root;
 
     if (argc == 1)
@@ -380,6 +380,9 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
     if (op == REG_IMPORT)
         return reg_import(argc, argvW);
 
+    if (op == REG_QUERY)
+        return reg_query(argc, argvW);
+
     if (!parse_registry_key(argvW[2], &root, &path, &key_name))
         return 1;
 
@@ -429,12 +432,6 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
                 }
                 break;
             case 's':
-                if (op == REG_QUERY)
-                {
-                    recurse = TRUE;
-                    break;
-                }
-
                 ptr = argvW[++i];
                 if (!ptr || lstrlenW(ptr) != 1)
                 {
@@ -461,9 +458,8 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
 
     if (op == REG_ADD)
         ret = reg_add(root, path, value_name, value_empty, type, separator, data, force);
-    else if (op == REG_DELETE)
-        ret = reg_delete(root, path, key_name, value_name, value_empty, value_all, force);
     else
-        ret = reg_query(root, path, key_name, value_name, value_empty, recurse);
+        ret = reg_delete(root, path, key_name, value_name, value_empty, value_all, force);
+
     return ret;
 }
diff --git a/programs/reg/reg.h b/programs/reg/reg.h
index 89492ae8f74..e1e4804d19d 100644
--- a/programs/reg/reg.h
+++ b/programs/reg/reg.h
@@ -57,7 +57,6 @@ int reg_export(int argc, WCHAR *argvW[]);
 int reg_import(int argc, WCHAR *argvW[]);
 
 /* query.c */
-int reg_query(HKEY root, WCHAR *path, WCHAR *key_name, WCHAR *value_name,
-              BOOL value_empty, BOOL recurse);
+int reg_query(int argc, WCHAR *argvW[]);
 
 #endif /* __REG_H__ */
-- 
2.31.0

[PATCH v2 2/2] reg: Fail if duplicate command-line switches are passed to 'reg query'

[Hugh McMaster]

Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com>
---
 programs/reg/query.c       | 2 ++
 programs/reg/tests/query.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/programs/reg/query.c b/programs/reg/query.c
index 7ae99fad6d5..c8277cd7114 100644
--- a/programs/reg/query.c
+++ b/programs/reg/query.c
@@ -344,6 +344,7 @@ int reg_query(int argc, WCHAR *argvW[])
 
             if (!lstrcmpiW(str, L"ve"))
             {
+                if (value_empty) goto invalid;
                 value_empty = TRUE;
                 continue;
             }
@@ -357,6 +358,7 @@ int reg_query(int argc, WCHAR *argvW[])
                     goto invalid;
                 break;
             case 's':
+                if (recurse) goto invalid;
                 recurse = TRUE;
                 break;
             default:
diff --git a/programs/reg/tests/query.c b/programs/reg/tests/query.c
index fcd43a4b195..e2b438f8c92 100644
--- a/programs/reg/tests/query.c
+++ b/programs/reg/tests/query.c
@@ -117,7 +117,7 @@ static void test_query(void)
        "got exit code %d, expected 0\n", r);
 
     run_reg_exe("reg query HKCU\\" KEY_BASE " /s /s", &r);
-    todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
+    ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
 
     /* Clean-up, then query */
     delete_key(key, "subkey");
-- 
2.31.0