[PATCH] conhost: Input should be restored and input_thread handle should be closed before return.
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=79104 Your paranoid android. === debiant (build log) === Task: WineTest did not produce the wow32 report
On 22.09.2020 08:26, Haidong Yu wrote:
+ if (console->is_unix) + { + unsigned int h = 0; + status = NtDeviceIoControlFile(console->server, NULL, NULL, NULL, &io, IOCTL_CONDRV_SETUP_INPUT, + &h, sizeof(h), NULL, 0); + if (status) ERR( "input restore failed: %#x\n", status ); + } + CloseHandle( console->input_thread ); + console->input_thread = NULL;
We should probably also terminate current read, like we do in the end of the function. Please break out of the loop instead of duplicating that code. Thanks, Jacek
participants (3)
-
Haidong Yu -
Jacek Caban -
Marvin