Re: [PATCH] msi/tests: Factor out success checks into table building functions.

[Hans Leidekker]

On Tue, 2017-09-19 at 00:23 -0500, Zebediah Figura wrote:
> @@ -3457,62 +3474,28 @@ static void test_join(void)
>      hdb = create_db();
>      ok( hdb, "failed to create db\n");
>
> -    r = create_component_table( hdb );
> -    ok( r == ERROR_SUCCESS, "cannot create Component table: %d\n", r );
> -
> -    r = add_component_entry( hdb, "'zygomatic', 'malar', 'INSTALLDIR', 0, '', ''" );
> -    ok( r == ERROR_SUCCESS, "cannot add component: %d\n", r );

Please add a line parameter to the add_* macros so we don't loose that information.

[PATCH] msi/tests: Factor out success checks into table building functions.

[Zebediah Figura]

On 09/19/2017 04:33 AM, Hans Leidekker wrote:
> On Tue, 2017-09-19 at 00:23 -0500, Zebediah Figura wrote:
> > @@ -3457,62 +3474,28 @@ static void test_join(void)
> >       hdb = create_db();
> >       ok( hdb, "failed to create db\n");
> >
> > -    r = create_component_table( hdb );
> > -    ok( r == ERROR_SUCCESS, "cannot create Component table: %d\n", r );
> > -
> > -    r = add_component_entry( hdb, "'zygomatic', 'malar', 'INSTALLDIR', 0, '', ''" );
> > -    ok( r == ERROR_SUCCESS, "cannot add component: %d\n", r );
>
> Please add a line parameter to the add_* macros so we don't loose that information.

Thanks, will do.