Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer.

[Vitaliy Margolen]

On 06/20/2011 04:06 PM, Lucas Fialho Zawacki wrote:
> @@ -1391,9 +1391,24 @@ HRESULT WINAPI IDirectInputDevice8AImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface
>       				     LPCSTR lpszUserName,
>       				     DWORD dwFlags)
>   {
> ...
> +    hr = IDirectInputDevice8_SetActionMap(&This->IDirectInputDevice8W_iface,
> +&diafW, NULL, dwFlags);
> You need to call IDirectInputDevice8WImpl_SetActionMap directly here. Also 
> please don't wrap lines at 80 characters, you can put all that into one 
> line. And please be consistent with spacing around parentheses - either put 
> spaces on both sides, or don't put at all.
> +        memset(&dp,0,sizeof(dp));
> Please don't needlessly zero structures. You setting most values of it 
> anyway. And please don't forget spaces after comas.

Otherwise looks really good!


Vitaliy.