Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command

[Frédéric Delanoy]

On Wed, Aug 24, 2011 at 08:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote:
> --
>
> I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy.
> ---
>  programs/attrib/Makefile.in |    4 +
>  programs/attrib/attrib.c    |  190 +++++++++++++++++++++++++++++++++++++++++--
>  programs/attrib/attrib.h    |   28 ++++++
>  programs/attrib/attrib.rc   |   49 +++++++++++
>  programs/cmd/builtins.c     |   83 -------------------
>  programs/cmd/cmd.rc         |    2
>  programs/cmd/wcmd.h         |   94 ++++++++++-----------
>  programs/cmd/wcmdmain.c     |    4 -
>  8 files changed, 309 insertions(+), 145 deletions(-)
>  create mode 100644 programs/attrib/attrib.h
>  create mode 100644 programs/attrib/attrib.rc

Most translatable strings (except those in dialogs) have been moved
to/adapted for use in po files.
You have to regenerate the po files using "make depend && make" in
maintainer mode (./configure --enable-maintainer-mode).

Frédéric

[PATCH] attrib: Move implementation from cmd.exe to the standalone command

[Frédéric Delanoy]

2011/8/24 Frédéric Delanoy <frederic.delanoy(a)gmail.com>:
> On Wed, Aug 24, 2011 at 08:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote:
> > --
> >
> > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy.
> > ---
> >  programs/attrib/Makefile.in |    4 +
> >  programs/attrib/attrib.c    |  190 +++++++++++++++++++++++++++++++++++++++++--
> >  programs/attrib/attrib.h    |   28 ++++++
> >  programs/attrib/attrib.rc   |   49 +++++++++++
> >  programs/cmd/builtins.c     |   83 -------------------
> >  programs/cmd/cmd.rc         |    2
> >  programs/cmd/wcmd.h         |   94 ++++++++++-----------
> >  programs/cmd/wcmdmain.c     |    4 -
> >  8 files changed, 309 insertions(+), 145 deletions(-)
> >  create mode 100644 programs/attrib/attrib.h
> >  create mode 100644 programs/attrib/attrib.rc
>
> Most translatable strings (except those in dialogs) have been moved
> to/adapted for use in po files.
> You have to regenerate the po files using "make depend && make" in
> maintainer mode (./configure --enable-maintainer-mode).
>
> Frédéric

Also, you should keep attrib current help strings, so "help" and "help
attrib" still work (they do in w2k for instance)