Re: [PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.

[Piotr Caban]

Hi Lauri,

On 12/13/16 19:48, Lauri Kenttä wrote:
> +    static const WCHAR zeros[] = {
> +        0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10,
> +        0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66
> +    };
> Please also add a test for Tibetan digits range:
> https://unicode-table.com/en/0F20/
> +    /* Test various unicode digits */
> +    for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) {
> +        WCHAR tmp[] = {zeros[i]+4, zeros[i], zeros[i]+5, 0};
> +        res = p_wcstoi64(tmp, NULL, 0);
> +        todo_wine ok(res == 405, "with zero = %#x: got %d, expected 405\n", zeros[i], (int)res);
> Could you please also add following test:
> tmp[1] = zeros[i]+10;
> res = p_wcstoi64(tmp, NULL, 16);
> ok(res == 4, ...);

Thank you,
Piotr

[PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.

[Lauri Kenttä]

On 2016-12-14 12:16, Piotr Caban wrote:
> Hi Lauri,
>
> On 12/13/16 19:48, Lauri Kenttä wrote:
> > +    static const WCHAR zeros[] = {
> > +        0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10,
> > +        0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66
> > +    };
> > Please also add a test for Tibetan digits range:
> > https://unicode-table.com/en/0F20/
> > +    /* Test various unicode digits */
> > +    for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) {
> > +        WCHAR tmp[] = {zeros[i]+4, zeros[i], zeros[i]+5, 0};
> > +        res = p_wcstoi64(tmp, NULL, 0);
> > +        todo_wine ok(res == 405, "with zero = %#x: got %d, expected 
> > 405\n", zeros[i], (int)res);
> > Could you please also add following test:
> > tmp[1] = zeros[i]+10;
> > res = p_wcstoi64(tmp, NULL, 16);
> > ok(res == 4, ...);
>
> Thank you,
> Piotr

Will do.

-- 
Lauri Kenttä