Re: wine/ windows/winproc.c windows/win.c windows/ ...

[Dimitrie O. Paun]

On August 12, 2003 07:50 pm, Alexandre Julliard wrote:
> Allocate DebugInfo field for all critical sections (based on a
> patch by Alex Pasadyn).
>         Get rid of the Wine-specific CRITICAL_SECTION_INIT macro.

+static CRITICAL_SECTION_DEBUG critsect_debug =
+{
+    0, 0, &winproc_cs,
+    { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList },
+      0, 0, { 0, (DWORD)(__FILE__ ": winproc_cs") }
+};

Can we use the C99 initializers, like they do in the Linux kernel? 
I think they'll do a better job in this case. This one looks a bit 
too cryptic for me.

-- 
Dimi.

wine/ windows/winproc.c windows/win.c windows/ ...

[Alexandre Julliard]

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes:
> Can we use the C99 initializers, like they do in the Linux kernel? 
> I think they'll do a better job in this case. This one looks a bit 
> too cryptic for me.

I don't think we want to depend on C99 features, no. It could be made
clearer with comments etc., but that declaration is just a magic
incantation that's not going to change, so IMO it doesn't really
matter if it's a bit cryptic.

-- 
Alexandre Julliard
julliard(a)winehq.com