[PATCH 6/6] msdasql: Fix use after free (Coverity)
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/msdasql/tests/provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index 63a51c6f60e..61b5dfc807d 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -130,8 +130,8 @@ static void test_Properties(void) hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); ok(hr == S_OK, "got 0x%08x\n", hr); - ok(propidlist.cPropertyIDs == 14, "got %d\n", propinfoset->cPropertyInfos); - ok(propset->cProperties == 14, "got %d\n", propinfoset->cPropertyInfos); + ok(propidlist.cPropertyIDs == 14, "got %d\n", propidlist.cPropertyIDs); + ok(propset->cProperties == 14, "got %d\n", propset->cProperties); for (i = 0; i < propidlist.cPropertyIDs; i++) { -- 2.33.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=101385 Your paranoid android. === w7u_2qxl (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w7u_adm (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w7u_el (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w8 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w8adm (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w864 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w1064v1507 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w1064v1809 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w1064 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w1064_tsign (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000 === w10pro64 (32 bit report) === msdasql: provider.c:420: Test failed: got 0x00000000
participants (2)
-
Alistair Leslie-Hughes -
Marvin