Re: [10/13] D3D9: Fix the circular converted vertex declaration reference

[H. Verbeet]

On 20/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> If anyone knows a nicer way to release the converted declaration from
> SetVertexDeclaration feel free to comment.
>
> Not applying this patch won't affect patches 11-13

Wouldn't it be better to directly compare This against convertedDecl
from the device in IDirect3DVertexDeclaration9Impl_Release, rather
than adding a convertedDecl flag to IDirect3DVertexDeclaration9Impl
and setting / unsetting it? I think it makes things harder than it has
to be. Also, afaik Ivan has some tests for the exact behaviour.

[10/13] D3D9: Fix the circular converted vertex declaration reference

[Ivan Gyurdiev]

H. Verbeet wrote:
> On 20/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> > If anyone knows a nicer way to release the converted declaration from
> > SetVertexDeclaration feel free to comment.
> >
> > Not applying this patch won't affect patches 11-13
>
> Wouldn't it be better to directly compare This against convertedDecl
> from the device in IDirect3DVertexDeclaration9Impl_Release, rather
> than adding a convertedDecl flag to IDirect3DVertexDeclaration9Impl
> and setting / unsetting it? I think it makes things harder than it has
> to be. Also, afaik Ivan has some tests for the exact behaviour.
> "Some tests" attached.  I cannot guarantee whether the tests make any 
> sense or are correct (don't remember what I was trying to do , but maybe 
> they'll be helpful :)

The converted declaration is evil... I lost patience when trying to 
figure out the exact behavior, so decided to leave it broken, rather 
than fix it incorrectly. I think I wasn't sure whether the conversion 
happens on the setFVF call, or on the GetDeclaration call following it.