[PATCH 4/5] user32: Store current spy indent in user_thread_info struct.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/user32/spy.c            | 13 ++-----------
  dlls/win32u/ntuser_private.h |  1 +
  2 files changed, 3 insertions(+), 11 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=110843

Your paranoid android.


=== debian11 (32 bit report) ===

user32:
input.c:2164: Test failed: Unexpected rawinput data: 3
input.c:2163: Test failed: Unexpected rawinput data: -2
input.c:2217: Test failed: Unexpected rawinput data: -4
input.c:1623: Test failed: expected to get 64 mouse move points but got 63
input.c:1628: Test failed: wrong position 1, expected 65x130 got 64x128
input.c:1628: Test failed: wrong position 4, expected 62x124 got 64x128
input.c:1628: Test failed: wrong position 5, expected 61x122 got 62x124
input.c:1628: Test failed: wrong position 6, expected 60x120 got 63x126
input.c:1628: Test failed: wrong position 7, expected 59x118 got 61x122
input.c:1628: Test failed: wrong position 8, expected 58x116 got 62x124
input.c:1628: Test failed: wrong position 9, expected 57x114 got 60x120
input.c:1628: Test failed: wrong position 10, expected 56x112 got 61x122
input.c:1628: Test failed: wrong position 11, expected 55x110 got 59x118
input.c:1628: Test failed: wrong position 13, expected 53x106 got 58x116
input.c:1628: Test failed: wrong position 15, expected 51x102 got 57x114
input.c:1628: Test failed: wrong position 16, expected 50x100 got 58x116
input.c:1628: Test failed: wrong position 17, expected 49x98 got 56x112
input.c:1628: Test failed: wrong position 19, expected 47x94 got 55x110
input.c:1628: Test failed: wrong position 20, expected 46x92 got 56x112
input.c:1628: Test failed: wrong position 21, expected 45x90 got 54x108
input.c:1628: Test failed: wrong position 23, expected 43x86 got 53x106
input.c:1628: Test failed: wrong position 24, expected 42x84 got 54x108
input.c:1628: Test failed: wrong position 25, expected 41x82 got 52x104
input.c:1628: Test failed: wrong position 26, expected 40x80 got 53x106
input.c:1628: Test failed: wrong position 27, expected 39x78 got 51x102
input.c:1628: Test failed: wrong position 28, expected 38x76 got 52x104
input.c:1628: Test failed: wrong position 29, expected 37x74 got 50x100
input.c:1628: Test failed: wrong position 30, expected 36x72 got 51x102
input.c:1628: Test failed: wrong position 31, expected 35x70 got 49x98
input.c:1628: Test failed: wrong position 33, expected 33x66 got 48x96
input.c:1628: Test failed: wrong position 35, expected 31x62 got 47x94
input.c:1628: Test failed: wrong position 37, expected 29x58 got 46x92
input.c:1628: Test failed: wrong position 38, expected 28x56 got 47x94
input.c:1628: Test failed: wrong position 39, expected 27x54 got 45x90
input.c:1628: Test failed: wrong position 41, expected 25x50 got 44x88
input.c:1628: Test failed: wrong position 42, expected 24x48 got 45x90
input.c:1628: Test failed: wrong position 43, expected 23x46 got 43x86
input.c:1628: Test failed: wrong position 45, expected 21x42 got 42x84
input.c:1628: Test failed: wrong position 46, expected 20x40 got 41x82
input.c:1628: Test failed: wrong position 49, expected 17x34 got 40x80
input.c:1628: Test failed: wrong position 50, expected 16x32 got 41x82
input.c:1628: Test failed: wrong position 51, expected 15x30 got 39x78
input.c:1628: Test failed: wrong position 53, expected 13x26 got 38x76
input.c:1628: Test failed: wrong position 54, expected 12x24 got 39x78
input.c:1628: Test failed: wrong position 55, expected 11x22 got 37x74
input.c:1628: Test failed: wrong position 57, expected 9x18 got 36x72
input.c:1628: Test failed: wrong position 59, expected 7x14 got 35x70
input.c:1628: Test failed: wrong position 61, expected 5x10 got 34x68
input.c:1628: Test failed: wrong position 62, expected 4x8 got 35x70
input.c:1695: Test failed: expected to get 64 mouse move points but got 63
win.c:11344: Test failed: expected 00DB00EA, got 00080136

=== debian11 (32 bit Chinese:China report) ===

user32:
input.c:3439: Test failed: expected WM_RBUTTONDOWN message
input.c:3440: Test failed: expected WM_RBUTTONUP message
input.c:3468: Test failed: expected WM_NCHITTEST message
input.c:3496: Test failed: expected WM_NCHITTEST message
input.c:2804: Test failed: 4: Unexpected cursor movement
input.c:2804: Test failed: 5: Unexpected cursor movement
input.c:2804: Test failed: 6: Unexpected cursor movement
input.c:2804: Test failed: 7: Unexpected cursor movement
input.c:2804: Test failed: 8: Unexpected cursor movement
input.c:2804: Test failed: 10: Unexpected cursor movement
input.c:2804: Test failed: 11: Unexpected cursor movement
input.c:2804: Test failed: 12: Unexpected cursor movement
input.c:2804: Test failed: 13: Unexpected cursor movement
input.c:2804: Test failed: 14: Unexpected cursor movement
input.c:2804: Test failed: 15: Unexpected cursor movement
input.c:2804: Test failed: 16: Unexpected cursor movement
input.c:1733: Test failed: expected to get 64 mouse move points but got 61
input.c:1744: Test failed: expected to get 64 mouse move points but got 61
monitor.c:471: Test failed: Invalid clip rect: (0,0)-(2048,768)
msg.c:15144: Test failed: bad time 4aed852
win.c:11353: Test failed: GetActiveWindow() = 00000000
win.c:11353: Test failed: GetFocus() = 00000000
win.c:11361: Test failed: expected 00BE010C, got 004E0090
win.c:11687: Test succeeded inside todo block: owner should be topmost
win.c:11690: Test succeeded inside todo block: hwnd2 should be topmost
win.c:11692: Test failed: owner should NOT be topmost
win.c:11693: Test failed: hwnd should NOT be topmost
win.c:11694: Test failed: hwnd2 should NOT be topmost
win.c:11698: Test failed: owner should NOT be topmost
win.c:11699: Test failed: hwnd should NOT be topmost
win.c:11700: Test failed: hwnd2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11708: Test failed: hwnd2 should NOT be topmost
win.c:11714: Test failed: hwnd2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11722: Test failed: hwnd2 should NOT be topmost
win.c:11728: Test failed: hwnd2 should NOT be topmost
win.c:11734: Test failed: hwnd should NOT be topmost
win.c:11735: Test failed: hwnd2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11756: Test failed: hwnd should NOT be topmost
win.c:11757: Test failed: hwnd2 should NOT be topmost
win.c:11758: Test failed: child should NOT be topmost
win.c:11759: Test failed: child2 should NOT be topmost
win.c:11760: Test failed: grandchild should NOT be topmost
win.c:11763: Test failed: 015000E4: expected NOT topmost
win.c:11768: Test succeeded inside todo block: hwnd should be topmost
win.c:11770: Test succeeded inside todo block: child should be topmost
win.c:11772: Test succeeded inside todo block: child2 should be topmost
win.c:11780: Test failed: hwnd should NOT be topmost
win.c:11781: Test failed: child should NOT be topmost
win.c:11782: Test failed: child2 should NOT be topmost
win.c:11787: Test failed: 015000E4: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11793: Test succeeded inside todo block: hwnd should be topmost
win.c:11795: Test succeeded inside todo block: child should be topmost
win.c:11797: Test succeeded inside todo block: child2 should be topmost
win.c:11805: Test failed: hwnd should NOT be topmost
win.c:11806: Test failed: child should NOT be topmost
win.c:11807: Test failed: child2 should NOT be topmost
win.c:11810: Test failed: 00C6009C: expected NOT topmost
win.c:11811: Test failed: 015000E4: expected next 00070148, got 00000000
win.c:11811: Test failed: 015000E4: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11817: Test succeeded inside todo block: hwnd should be topmost
win.c:11819: Test succeeded inside todo block: child should be topmost
win.c:11821: Test succeeded inside todo block: child2 should be topmost
win.c:11829: Test failed: hwnd should NOT be topmost
win.c:11830: Test failed: child should NOT be topmost
win.c:11831: Test failed: child2 should NOT be topmost
win.c:11834: Test failed: 00C6009C: expected NOT topmost
win.c:11835: Test failed: 015000E4: expected next 00070148, got 00000000
win.c:11835: Test failed: 015000E4: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11840: Test failed: hwnd should NOT be topmost
win.c:11842: Test succeeded inside todo block: child should be topmost
win.c:11843: Test failed: child2 should NOT be topmost
win.c:11851: Test failed: hwnd should NOT be topmost
win.c:11853: Test succeeded inside todo block: child should be topmost
win.c:11854: Test failed: child2 should NOT be topmost
win.c:11862: Test failed: hwnd should NOT be topmost
win.c:11863: Test failed: child should NOT be topmost
win.c:11864: Test failed: child2 should NOT be topmost
win.c:11869: Test failed: 015000E4: expected next 00070148, got 00000000
win.c:11869: Test failed: 015000E4: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11874: Test failed: hwnd should NOT be topmost
win.c:11876: Test succeeded inside todo block: child should be topmost
win.c:11877: Test failed: child2 should NOT be topmost
win.c:11885: Test failed: hwnd should NOT be topmost
win.c:11886: Test failed: child should NOT be topmost
win.c:11887: Test failed: child2 should NOT be topmost
win.c:11892: Test failed: 015000E4: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11897: Test failed: hwnd should NOT be topmost
win.c:11898: Test failed: child should NOT be topmost
win.c:11899: Test failed: child2 should NOT be topmost
win.c:11903: Test failed: 015000E4: expected next 00070148, got 00000000
win.c:11903: Test failed: 015000E4: expected NOT topmost
win.c:11906: Test failed: hwnd should NOT be topmost
win.c:11907: Test failed: child should NOT be topmost
win.c:11908: Test failed: child2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11918: Test failed: hwnd should NOT be topmost
win.c:11920: Test succeeded inside todo block: child should be topmost
win.c:11921: Test failed: child2 should NOT be topmost
win.c:11929: Test failed: hwnd should NOT be topmost
win.c:11930: Test failed: child should NOT be topmost
win.c:11931: Test failed: child2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost
win.c:11942: Test failed: hwnd should NOT be topmost
win.c:11944: Test succeeded inside todo block: child should be topmost
win.c:11945: Test failed: child2 should NOT be topmost
win.c:11953: Test failed: hwnd should NOT be topmost
win.c:11954: Test failed: child should NOT be topmost
win.c:11955: Test failed: child2 should NOT be topmost
win.c:11606: Test failed: 1: hwnd 00C6009C is still topmost
win.c:11606: Test failed: 2: hwnd 001800C4 is still topmost
win.c:11606: Test failed: 3: hwnd 00070148 is still topmost
win.c:11606: Test failed: 4: hwnd 015000E4 is still topmost

=== debian11 (32 bit WoW report) ===

user32:
input.c:1293: Test failed: GetCursorPos: (97,100)
input.c:1293: Test failed: GetCursorPos: (103,100)
input.c:1293: Test failed: GetCursorPos: (103,100)
input.c:1293: Test failed: GetCursorPos: (103,106)
input.c:1293: Test failed: GetCursorPos: (103,103)
input.c:2163: Test failed: Unexpected rawinput data: -8
input.c:2164: Test failed: Unexpected rawinput data: 5
input.c:2160: Test failed: GetRawInputBuffer returned 10
input.c:2162: Test failed: Unexpected rawinput data: -5
input.c:2164: Test failed: Unexpected rawinput data: 6
input.c:2217: Test failed: Unexpected rawinput data: 5
input.c:2155: Test failed: GetRawInputBuffer returned unexpected size: 0
input.c:2160: Test failed: GetRawInputBuffer returned 0
input.c:2161: Test failed: GetRawInputBuffer returned unexpected size: 0
input.c:2163: Test failed: Unexpected rawinput data: 0
input.c:2164: Test failed: Unexpected rawinput data: 0
input.c:1628: Test failed: wrong position 2, expected 64x128 got 63x126
input.c:1628: Test failed: wrong position 3, expected 63x126 got 64x128
input.c:1628: Test failed: wrong position 5, expected 61x122 got 63x126
input.c:1628: Test failed: wrong position 6, expected 60x120 got 61x122
input.c:1628: Test failed: wrong position 7, expected 59x118 got 62x124
input.c:1628: Test failed: wrong position 8, expected 58x116 got 60x120
input.c:1628: Test failed: wrong position 9, expected 57x114 got 61x122
input.c:1628: Test failed: wrong position 10, expected 56x112 got 59x118
input.c:1628: Test failed: wrong position 11, expected 55x110 got 60x120
input.c:1628: Test failed: wrong position 12, expected 54x108 got 58x116
input.c:1628: Test failed: wrong position 13, expected 53x106 got 59x118
input.c:1628: Test failed: wrong position 14, expected 52x104 got 57x114
input.c:1628: Test failed: wrong position 15, expected 51x102 got 58x116
input.c:1628: Test failed: wrong position 16, expected 50x100 got 56x112
input.c:1628: Test failed: wrong position 17, expected 49x98 got 55x110
input.c:1628: Test failed: wrong position 21, expected 45x90 got 55x110
input.c:1628: Test failed: wrong position 22, expected 44x88 got 53x106
input.c:1628: Test failed: wrong position 25, expected 41x82 got 53x106
input.c:1628: Test failed: wrong position 26, expected 40x80 got 51x102
input.c:1628: Test failed: wrong position 27, expected 39x78 got 50x100
input.c:1628: Test failed: wrong position 28, expected 38x76 got 52x104
input.c:1628: Test failed: wrong position 29, expected 37x74 got 51x102
input.c:1628: Test failed: wrong position 30, expected 36x72 got 49x98
input.c:1628: Test failed: wrong position 31, expected 35x70 got 48x96
input.c:1628: Test failed: wrong position 32, expected 34x68 got 47x94
input.c:1628: Test failed: wrong position 33, expected 33x66 got 50x100
input.c:1628: Test failed: wrong position 38, expected 28x56 got 47x94
input.c:1628: Test failed: wrong position 39, expected 27x54 got 44x88
input.c:1628: Test failed: wrong position 40, expected 26x52 got 46x92
input.c:1628: Test failed: wrong position 41, expected 25x50 got 43x86
input.c:1628: Test failed: wrong position 42, expected 24x48 got 45x90
input.c:1628: Test failed: wrong position 43, expected 23x46 got 42x84
input.c:1628: Test failed: wrong position 44, expected 22x44 got 41x82
input.c:1628: Test failed: wrong position 45, expected 21x42 got 44x88
input.c:1628: Test failed: wrong position 46, expected 20x40 got 43x86
input.c:1628: Test failed: wrong position 47, expected 19x38 got 40x80
input.c:1628: Test failed: wrong position 48, expected 18x36 got 42x84
input.c:1628: Test failed: wrong position 49, expected 17x34 got 39x78
input.c:1628: Test failed: wrong position 50, expected 16x32 got 38x76
input.c:1628: Test failed: wrong position 51, expected 15x30 got 41x82
input.c:1628: Test failed: wrong position 55, expected 11x22 got 38x76
input.c:1628: Test failed: wrong position 56, expected 10x20 got 36x72
input.c:1674: Test failed: cursor didn't change position after mouse_event()
input.c:1680: Test failed: wrong extra info, got 0x0 expected 0xcafecafe
monitor.c:467: Test failed: Invalid clip rect: (0,0)-(2048,768)
win.c:11344: Test failed: expected 00DB00EA, got 00420142

=== debian11 (64 bit WoW report) ===

user32:
input.c:2163: Test failed: Unexpected rawinput data: -8
input.c:2217: Test failed: Unexpected rawinput data: 2
input.c:1623: Test failed: expected to get 64 mouse move points but got 63
input.c:1628: Test failed: wrong position 1, expected 65x130 got 64x128
input.c:1628: Test failed: wrong position 2, expected 64x128 got 63x126
input.c:1628: Test failed: wrong position 3, expected 63x126 got 65x130
input.c:1628: Test failed: wrong position 4, expected 62x124 got 64x128
input.c:1628: Test failed: wrong position 5, expected 61x122 got 62x124
input.c:1628: Test failed: wrong position 6, expected 60x120 got 63x126
input.c:1628: Test failed: wrong position 7, expected 59x118 got 61x122
input.c:1628: Test failed: wrong position 8, expected 58x116 got 62x124
input.c:1628: Test failed: wrong position 9, expected 57x114 got 60x120
input.c:1628: Test failed: wrong position 10, expected 56x112 got 61x122
input.c:1628: Test failed: wrong position 11, expected 55x110 got 59x118
input.c:1628: Test failed: wrong position 12, expected 54x108 got 60x120
input.c:1628: Test failed: wrong position 14, expected 52x104 got 59x118
input.c:1628: Test failed: wrong position 15, expected 51x102 got 57x114
input.c:1628: Test failed: wrong position 16, expected 50x100 got 58x116
input.c:1628: Test failed: wrong position 17, expected 49x98 got 56x112
input.c:1628: Test failed: wrong position 18, expected 48x96 got 57x114
input.c:1628: Test failed: wrong position 20, expected 46x92 got 56x112
input.c:1628: Test failed: wrong position 21, expected 45x90 got 54x108
input.c:1628: Test failed: wrong position 22, expected 44x88 got 55x110
input.c:1628: Test failed: wrong position 23, expected 43x86 got 53x106
input.c:1628: Test failed: wrong position 24, expected 42x84 got 54x108
input.c:1628: Test failed: wrong position 26, expected 40x80 got 53x106
input.c:1628: Test failed: wrong position 27, expected 39x78 got 51x102
input.c:1628: Test failed: wrong position 28, expected 38x76 got 52x104
input.c:1628: Test failed: wrong position 30, expected 36x72 got 51x102
input.c:1628: Test failed: wrong position 31, expected 35x70 got 49x98
input.c:1628: Test failed: wrong position 32, expected 34x68 got 50x100
input.c:1628: Test failed: wrong position 33, expected 33x66 got 48x96
input.c:1628: Test failed: wrong position 34, expected 32x64 got 49x98
input.c:1628: Test failed: wrong position 35, expected 31x62 got 47x94
input.c:1628: Test failed: wrong position 36, expected 30x60 got 48x96
input.c:1628: Test failed: wrong position 38, expected 28x56 got 47x94
input.c:1628: Test failed: wrong position 39, expected 27x54 got 45x90
input.c:1628: Test failed: wrong position 40, expected 26x52 got 46x92
input.c:1628: Test failed: wrong position 41, expected 25x50 got 44x88
input.c:1628: Test failed: wrong position 42, expected 24x48 got 45x90
input.c:1628: Test failed: wrong position 44, expected 22x44 got 44x88
input.c:1628: Test failed: wrong position 45, expected 21x42 got 42x84
input.c:1628: Test failed: wrong position 46, expected 20x40 got 43x86
input.c:1628: Test failed: wrong position 47, expected 19x38 got 41x82
input.c:1628: Test failed: wrong position 48, expected 18x36 got 42x84
input.c:1628: Test failed: wrong position 49, expected 17x34 got 40x80
input.c:1628: Test failed: wrong position 50, expected 16x32 got 41x82
input.c:1628: Test failed: wrong position 51, expected 15x30 got 39x78
input.c:1628: Test failed: wrong position 52, expected 14x28 got 40x80
input.c:1628: Test failed: wrong position 54, expected 12x24 got 39x78
input.c:1628: Test failed: wrong position 55, expected 11x22 got 37x74
input.c:1628: Test failed: wrong position 56, expected 10x20 got 38x76
input.c:1628: Test failed: wrong position 57, expected 9x18 got 36x72
input.c:1628: Test failed: wrong position 58, expected 8x16 got 37x74
input.c:1628: Test failed: wrong position 59, expected 7x14 got 35x70
input.c:1628: Test failed: wrong position 60, expected 6x12 got 36x72
input.c:1628: Test failed: wrong position 61, expected 5x10 got 34x68
input.c:1628: Test failed: wrong position 62, expected 4x8 got 35x70

[Huw Davies]

Signed-off-by: Huw Davies <huw(a)codeweavers.com>