Re: [PATCH 1/1] ntdll: Fix section header heap deadlock (try 2).
"Erich E. Hoover" <ehoover(a)mines.edu> writes:
Description: Free the section header memory outside of the uninterrupted section lock. Changing the order here stops the process heap from potentially deadlocking (Bug #30356).
The allocation will still be an issue. I think a better approach would be to avoid any memory allocation in there. -- Alexandre Julliard julliard(a)winehq.org
On Thu, Apr 5, 2012 at 6:37 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
"Erich E. Hoover" <ehoover(a)mines.edu> writes:
Description: Free the section header memory outside of the uninterrupted section lock. Changing the order here stops the process heap from potentially deadlocking (Bug #30356).
The allocation will still be an issue. I think a better approach would be to avoid any memory allocation in there.
Do you want the uninterrupted section broken up into two parts or is there something else you had in mind? Erich Hoover ehoover(a)mines.edu
"Erich E. Hoover" <ehoover(a)mines.edu> writes:
On Thu, Apr 5, 2012 at 6:37 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
"Erich E. Hoover" <ehoover(a)mines.edu> writes:
Description: Free the section header memory outside of the uninterrupted section lock. Changing the order here stops the process heap from potentially deadlocking (Bug #30356).
The allocation will still be an issue. I think a better approach would be to avoid any memory allocation in there.
Do you want the uninterrupted section broken up into two parts or is there something else you had in mind?
Just use a fixed-size buffer on the stack or something along those lines. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Erich E. Hoover