Re: [PATCH 2/4] ddraw/tests: The testbot applies color keying without a key.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12332 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/20/15 13:20, Marvin wrote:
=== w8 (32 bit ddraw1) === ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080. Afaics this is a separate random failure in this test. I have seen it a few times when submitting patches, but I wasn't able to reproduce it when sending a patch through the web interface. I'll look into this bug as well.
Notice that e.g. the follow-up patch doesn't show the issue: http://testbot.winehq.org/JobDetails.pl?Key=12333 . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVDCf7AAoJEN0/YqbEcdMwrNwP/iQ7Ipr7ixEv2aglx2GxdFhJ Km3XNodYCwXcwGRYzBZlXjlJu8kXZPP+GqtcW0qXt0g/MXoFHpiO5wsgwHSRRPS7 yQ9fH6+SUcxRwrgq2iSAIon+LvHCDvcME+QdgD1j1vH7qOMWR6zWAXpCz9O/xHNm jIu2iAS9nXBrmdqSfJYWgSQnfsXxXUwnmVgKYGUuKWPx1N+SPp/L6ztj11ABCv5+ eiLIirftu4rNJWOEGHoVBEASDTaueg+rpeNX25S8P5KkMAcj/BWuGlKrbZAx38v6 scuYu5irbt3kXlbpklc5BJ83isQlt3HCat0ulGFOH4sTEg2ULuS3A20T9Hi3egQb lc8dgEv7LXvb5JxVfMYDBVtlvsZGaJjOJ3jolUsBHXETQaO7L5VrwyS/CDxhRbV3 ERJ8g6FqRROIfqul0gExuE7M84uuPQnNXnqSRzRUhk8xyE/3+B5ehSGgvMzZ3+z1 jIJh92Y9r/ZLAM7xcyJ9c+ByynEA8eSkcqlA6bXg54xskiOclKNLaFd2kdHUsJp6 82MTjJt7/pZDdL+QXOERotQ7g0uzSo1SHNYHXdLnbiqjZqj78mmQeTMXhX0rYtUG XN30ZCmYQ/nz3nmbuXzaYuruB7C/E2w1v/bkPqYZ+SCasGqehmU8F3ooqSjrYrTQ JEsm+woXHRPYX0jmrkoC =h5oo -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-20 um 13:20 schrieb Marvin:
ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080. It seems that the attached patch fixes the problem. I've run it through the testbot 5 times and this kind of failure was reliably gone with it.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVDsINAAoJEN0/YqbEcdMwTRYP/RyoA1T6xacQrIFT194ArhVy Swp5fKeGxJl43jtImkCRwjp8ZAx8+TNYCr2wmwZ84LiZG9v5oWO6UOKJXZGMfOUH 1vYuJS3Cm8ArvFcYall3HReoNn51NhVJufbtmmMlFXwXvIe7kHwc+gF9DSqeF5ke J3EugKGKKsvsVRSrCaBmNGPLAjctPngEy+YQ3JcojRKjHDQ9k22XpKOCQKtO/+KK 80xf00goneiUAr3TuRloWb1/Lpf/TMIPqbPEar682yb1H571T6wCkL1Rq8eUu7gn phI0MiTgLLTTIIdWzb+uhEFV3hjfrqgzRsJ6wDKJnE24Gcp9ayw+N93Y1j7P9oJg 8O8syZFQChpHWoycFK5gCF/zBofWVNjhNuBFhw+/Eq0gx6vyzb5RZroqoesYKg7b 89JsorfX86VBZwqkgDmr2ODwZaFTE8IICIgkaobphEnvkf4apzxbs6lT+FseixA0 IatE61JeqP+f1hu+hqugu05rr7NjXkqpVcNbdN0UxnV4CTgYbOJjCdPs6oFQfqi7 6C0juaWMQ+TpbQG7pbGGJTP1dVaW3OuzYAK96HAiVWrc474Eaz3mYS0eQc5pGK1a mCsQEtJh/ajtlwoMdQPU/NbN8tDEKT/Zqe6osHFM7ajQ70wCjlmPVnUhpREKg9Aw XgWDnn/KUl71UeNg5enk =R2wI -----END PGP SIGNATURE-----
participants (2)
-
Marvin -
Stefan Dösinger