[PATCH 3/3] windowscodecs: Implement DdsFrameDecode_Dds_CopyBlocks().

[Ziqing Hui]

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com>
---
 dlls/windowscodecs/ddsformat.c       | 41 ++++++++++++++++++++++++++--
 dlls/windowscodecs/tests/ddsformat.c | 30 ++++++++++----------
 2 files changed, 54 insertions(+), 17 deletions(-)

[Esme Povirk (they/them)]

+    if (!boundsInBlocks) {
+        size = This->info.width_in_blocks *
This->info.height_in_blocks * This->info.bytes_per_block;
+        if (bufferSize < size) return E_INVALIDARG;
+        memcpy(buffer, This->data, size);
+        return S_OK;
+    }

This ignores the stride passed in. Are you sure about this?

[Ziqing Hui]

I'm not sure... I'll write some test code to find out.

On 6/6/20 12:01 AM, Esme Povirk (they/them) wrote:
> +    if (!boundsInBlocks) {
> +        size = This->info.width_in_blocks *
> This->info.height_in_blocks * This->info.bytes_per_block;
> +        if (bufferSize < size) return E_INVALIDARG;
> +        memcpy(buffer, This->data, size);
> +        return S_OK;
> +    }
>
> This ignores the stride passed in. Are you sure about this?