Re: MSHTML: THIS macros clean up

[Dimi Paun]

----- Original Message ----- 
From: "Jacek Caban" <jack(a)itma.pwr.wroc.pl>
> @@ -78,29 +77,35 @@ static HRESULT WINAPI PersistMoniker_IsD
>  static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL
> fFullyAvailable,
>          IMoniker *pimkName, LPBC pibc, DWORD grfMode)
>  {
> -    FIXME("(%p)->(%x %p %p %08lx)\n", iface, fFullyAvailable, pimkName,
> pibc, grfMode);
> +    PERSISTMON_THIS
> +    FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName,
> pibc, grfMode);
>      return S_OK;
>  }

This code looks weird. It should still look like C code,
even if we use a macro. I would suggest something like this:

static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL
fFullyAvailable,
        IMoniker *pimkName, LPBC pibc, DWORD grfMode)
{
    HTMLDocument *This = PERSISTMON_THIS(iface);

    FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc,
grfMode);
    return S_OK;
}

It's a bit more verbose, but a lot more readable.

-- 
Dimi Paun <dimi(a)lattica.com>
Lattica, Inc.