Re: [advapi32/tests] Only use functions if they are implemented

[James Hawkins]

On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> Hi,
>
> Added some verbosity to the GetProcAddress stuff. The skips prevent the
> crash(es) I'm seeing on win95.

What is the point of this 'verbosity'?  You already add the skips, so
if a function isn't available for a test, you're going to see it twice
now.  Also, it adds to the code size.

-- 
James Hawkins

[advapi32/tests] Only use functions if they are implemented

[Paul Vriens]

James Hawkins wrote:
> On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> > Hi,
> >
> > Added some verbosity to the GetProcAddress stuff. The skips prevent the
> > crash(es) I'm seeing on win95.
>
> What is the point of this 'verbosity'?  You already add the skips, so
> if a function isn't available for a test, you're going to see it twice
> now.  Also, it adds to the code size.

I did the 'verbosity' to find out the missing functions before I did the skips 
in the first place. As a lot of the tests are still not running on all platforms 
I've added these extra trace.

If needed I'll sent a patch with just the skips.

There are a lot of tests already with these extra traces (and yes I'm guilty). 
Maybe we should have a janitorial task once we have a green testpage.

-- 
Cheers,

Paul.