Re: [PATCH v2] ntoskrnl.exe: fix handling relocations on page boundary

[Rafał H]

Why this is deferred. I hoped to have it included in Wine 4.0. It fixes kernel driver crashes for multiple games (StarForce v3, Age of Wushu, MTA: SA, makes the last one totally working, no idea about others) and is not intrusive at all. If not crash-fixes than what is accepted type of patches right now before Wine 4.0?

W dniu 11.01.2019 o 19:05, Marvin pisze:

Thank you for your contribution to Wine!

This is an automated notification to let you know that your patch has
been reviewed and its status set to "Deferred".

This means that the patch is deferred because of code freeze for an
upcoming release. You need to either resend after the release, make
the patch less intrusive, or make a convincing argument that it needs
to be included in the release.

If you do not understand the reason for this status, disagree with our
assessment, or are simply not sure how to proceed next, please ask for
clarification by replying to this email.

[PATCH v2] ntoskrnl.exe: fix handling relocations on page boundary

[Alexandre Julliard]

Rafał H <rafalh92(a)outlook.com> writes:
> Why this is deferred. I hoped to have it included in Wine 4.0. It
> fixes kernel driver crashes for multiple games (StarForce v3, Age of
> Wushu, MTA: SA, makes the last one totally working, no idea about
> others) and is not intrusive at all. If not crash-fixes than what is
> accepted type of patches right now before Wine 4.0?

At this point, mostly small targeted regression fixes.

This patch is pretty large, it's not obvious that it's not breaking the
existing code path, it hasn't seen much testing yet, and it's not fixing
a regression. As such I feel it's not safe enough to go in, especially
since we are already at rc6 and I expect final 4.0 in a week or so. I'm
afraid it will have to wait; it can always be cherry-picked into 4.0.1.

-- 
Alexandre Julliard
julliard(a)winehq.org