Re: [PATCH] hid: implement HidD_SetOutputReport

[Sebastian Lackner]

On 24.10.2016 16:06, Aric Stewart wrote:
> Also fixes an issue with IOCTL_HID_SET_FEATURE where the wrong buffers where being sent.
>
> Signed-off-by: Aric Stewart <aric(a)codeweavers.com>
> ---
>  dlls/hid/hid.spec          |  2 +-
>  dlls/hid/hidd.c            |  6 ++++++
>  dlls/hidclass.sys/device.c | 11 +++++++----
>  include/ddk/hidsdi.h       |  1 +
>  4 files changed, 15 insertions(+), 5 deletions(-)

While you are just at it, shouldn't the first char in SystemBuffer be skipped?

"packet.reportBuffer = irp->AssociatedIrp.SystemBuffer;"

Also, it looks like the first assignment of

"irp->IoStatus.Information = 0;"

is not really required, its also assigned later.

Regards,
Sebastian