[PATCH 5/6] adsldp: only report search errors when iterating results
It's unclear whether MSDN's claim that searches are deferred until GetFirstRow()/GetNextRow() is true, but .NET is extremely unhappy if IDirectorySearch::ExecuteSearch() fails, and even if a query with 0 results returns something other than S_ADS_NOMORE_ROWS. For now, at least delay returning the search error until GetFirstRow()/GetNextRow(). Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> --- dlls/adsldp/adsldp.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
Damjan Jovanovic <damjan.jov(a)gmail.com> wrote:
It's unclear whether MSDN's claim that searches are deferred until GetFirstRow()/GetNextRow() is true, but .NET is extremely unhappy if IDirectorySearch::ExecuteSearch() fails, and even if a query with 0 results returns something other than S_ADS_NOMORE_ROWS. For now, at least delay returning the search error until GetFirstRow()/GetNextRow().
Please add a test case for this. -- Dmitry.
participants (2)
-
Damjan Jovanovic -
Dmitry Timoshkov