Re: dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.

[Paul Vriens]

Robert Shearman wrote:
> ---
>  dlls/dxdiagn/provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> ------------------------------------------------------------------------

Hi Rob,

Is there a need to have it assigned, as the next line overwrites boolret again?

-- 
Cheers,

Paul.

dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.

[Robert Shearman]

Paul Vriens wrote:
> Robert Shearman wrote:
> > ---
> >  dlls/dxdiagn/provider.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > ------------------------------------------------------------------------
>
> Is there a need to have it assigned, as the next line overwrites 
> boolret again?

When somebody bothers to actually do some error checking in the function 
it will be a better starting point.

-- 
Rob Shearman