[PATCH] ntdll: Add stub for NtSetDebugFilterState().

[Paul Gofman]

Eternal Return benefited from this function present as .spec file
stub which was removed by 52202224d9ab8316896370db2af6399a5fb7b916.

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com>
---
    The game doesn't call it, just queries and hotpatches.

v2:
    - added description to the patch indicating that it fixes a regression.

 dlls/ntdll/ntdll.spec    |  4 ++--
 dlls/ntdll/unix/debug.c  | 11 +++++++++++
 dlls/ntdll/unix/loader.c |  1 +
 dlls/wow64/syscall.c     | 13 +++++++++++++
 dlls/wow64/syscall.h     |  1 +
 include/winternl.h       |  1 +
 6 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec
index f16943aacd9..3dfde915e50 100644
--- a/dlls/ntdll/ntdll.spec
+++ b/dlls/ntdll/ntdll.spec
@@ -367,7 +367,7 @@
 # @ stub NtSetBootEntryOrder
 # @ stub NtSetBootOptions
 @ stdcall -syscall NtSetContextThread(long ptr)
-# @ stub NtSetDebugFilterState
+@ stdcall -syscall NtSetDebugFilterState(long long long)
 # @ stub NtSetDefaultHardErrorPort
 @ stdcall -syscall NtSetDefaultLocale(long long)
 @ stdcall -syscall NtSetDefaultUILanguage(long)
@@ -1389,7 +1389,7 @@
 # @ stub ZwSetBootEntryOrder
 # @ stub ZwSetBootOptions
 @ stdcall -private -syscall ZwSetContextThread(long ptr) NtSetContextThread
-# @ stub ZwSetDebugFilterState
+@ stdcall -private -syscall ZwSetDebugFilterState(long ptr) NtSetDebugFilterState
 # @ stub ZwSetDefaultHardErrorPort
 @ stdcall -private -syscall ZwSetDefaultLocale(long long) NtSetDefaultLocale
 @ stdcall -private -syscall ZwSetDefaultUILanguage(long) NtSetDefaultUILanguage
diff --git a/dlls/ntdll/unix/debug.c b/dlls/ntdll/unix/debug.c
index 63846875c86..e840f5c6e3d 100644
--- a/dlls/ntdll/unix/debug.c
+++ b/dlls/ntdll/unix/debug.c
@@ -353,3 +353,14 @@ NTSTATUS WINAPI NtTraceControl( ULONG code, void *inbuf, ULONG inbuf_len,
            outbuf, outbuf_len, size );
     return STATUS_SUCCESS;
 }
+
+
+/***********************************************************************
+ *              NtSetDebugFilterState  (NTDLL.@)
+ */
+NTSTATUS WINAPI NtSetDebugFilterState( ULONG component_id, ULONG level, BOOLEAN state )
+{
+    FIXME( "component_id %#x, level %u, state %#x stub.\n", component_id, level, state );
+
+    return STATUS_SUCCESS;
+}
diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c
index 2d6b81ef651..0bb254ba700 100644
--- a/dlls/ntdll/unix/loader.c
+++ b/dlls/ntdll/unix/loader.c
@@ -294,6 +294,7 @@ static void * const syscalls[] =
     NtSaveKey,
     NtSecureConnectPort,
     NtSetContextThread,
+    NtSetDebugFilterState,
     NtSetDefaultLocale,
     NtSetDefaultUILanguage,
     NtSetEaFile,
diff --git a/dlls/wow64/syscall.c b/dlls/wow64/syscall.c
index 75a5df5c453..cae23da8e76 100644
--- a/dlls/wow64/syscall.c
+++ b/dlls/wow64/syscall.c
@@ -269,6 +269,19 @@ NTSTATUS WINAPI wow64_NtQueryInstallUILanguage( UINT *args )
 }
 
 
+/**********************************************************************
+ *           wow64_NtSetDebugFilterState
+ */
+NTSTATUS WINAPI wow64_NtSetDebugFilterState( UINT *args )
+{
+    ULONG component_id = get_ulong( &args );
+    ULONG level = get_ulong( &args );
+    BOOLEAN state = get_ulong( &args );
+
+    NtSetDebugFilterState( component_id, level, state );
+}
+
+
 /**********************************************************************
  *           wow64_NtSetDefaultLocale
  */
diff --git a/dlls/wow64/syscall.h b/dlls/wow64/syscall.h
index 1e122e97314..0c2ba574031 100644
--- a/dlls/wow64/syscall.h
+++ b/dlls/wow64/syscall.h
@@ -196,6 +196,7 @@
     SYSCALL_ENTRY( NtSaveKey ) \
     SYSCALL_ENTRY( NtSecureConnectPort ) \
     SYSCALL_ENTRY( NtSetContextThread ) \
+    SYSCALL_ENTRY( NtSetDebugFilterState ) \
     SYSCALL_ENTRY( NtSetDefaultLocale ) \
     SYSCALL_ENTRY( NtSetDefaultUILanguage ) \
     SYSCALL_ENTRY( NtSetEaFile ) \
diff --git a/include/winternl.h b/include/winternl.h
index 29ab0a7ae24..7c3a0c3cf57 100644
--- a/include/winternl.h
+++ b/include/winternl.h
@@ -4067,6 +4067,7 @@ NTSYSAPI NTSTATUS  WINAPI NtResumeThread(HANDLE,PULONG);
 NTSYSAPI NTSTATUS  WINAPI NtSaveKey(HANDLE,HANDLE);
 NTSYSAPI NTSTATUS  WINAPI NtSecureConnectPort(PHANDLE,PUNICODE_STRING,PSECURITY_QUALITY_OF_SERVICE,PLPC_SECTION_WRITE,PSID,PLPC_SECTION_READ,PULONG,PVOID,PULONG);
 NTSYSAPI NTSTATUS  WINAPI NtSetContextThread(HANDLE,const CONTEXT*);
+NTSYSAPI NTSTATUS  WINAPI NtSetDebugFilterState(ULONG,ULONG,BOOLEAN);
 NTSYSAPI NTSTATUS  WINAPI NtSetDefaultHardErrorPort(HANDLE);
 NTSYSAPI NTSTATUS  WINAPI NtSetDefaultLocale(BOOLEAN,LCID);
 NTSYSAPI NTSTATUS  WINAPI NtSetDefaultUILanguage(LANGID);
-- 
2.33.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=104028

Your paranoid android.


=== debian11 (build log) ===

/usr/bin/i686-w64-mingw32-ld: ntdll.dll-61c415fe.spec.o:fake:(.edata+0x1178): undefined reference to `NtSetDebugFilterState(a)8'
collect2: error: ld returned 1 exit status
Task: The win32 Wine build failed

=== debian11 (build log) ===

/usr/bin/i686-w64-mingw32-ld: ntdll.dll-61c48336.spec.o:fake:(.edata+0x1178): undefined reference to `NtSetDebugFilterState(a)8'
collect2: error: ld returned 1 exit status
Task: The wow32 Wine build failed