Re: winmm: MCI system commands are not eligible for auto-open. (try 2)
12 Apr
2010
12 Apr
'10
4:43 p.m.
[cc:ing wine-devel] <Joerg-Cyril.Hoehle(a)t-systems.com> wrote:
this is the second time that AJ commits a patch of mine despite a comment of yours.
I think that Alexandre has commited your patch slightly in a hurry, usually he waits at least several hours unless the patch is obviously correct (which is not the case here IMO).
Should I send a subsequent patch that takes all your comments into consideration?
In my opinion your patch should be reverted until all the changes have appropriate test cases, and that patch makes the tests pass (i.e. remove existing todo_wine statements). -- Dmitry.
5813
Age (days ago)
5813
Last active (days ago)
0 comments
1 participants
participants (1)
-
Dmitry Timoshkov