Re: richedit: empty text should result in a scroll range of 0. Tests for this behavior.
Alex Villacís Lasso a écrit :
Even though the code freeze is still in effect, I post this so that it will be reviewed. For more information, see bug #12311.
Changelog: * richedit: empty text should result in a scroll range of 0. * Tests for this behavior.
------------------------------------------------------------------------
what I don't understand is why the height of an empty doc is not zero (I had similar issues with the height of a doc where we systematically get one row too much). I believe this root cause should be fixed instead of the band aid your patch is providing A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)
Eric Pouech escribió:
Alex Villacís Lasso a écrit :
Even though the code freeze is still in effect, I post this so that it will be reviewed. For more information, see bug #12311.
Changelog: * richedit: empty text should result in a scroll range of 0. * Tests for this behavior.
------------------------------------------------------------------------
what I don't understand is why the height of an empty doc is not zero (I had similar issues with the height of a doc where we systematically get one row too much). I believe this root cause should be fixed instead of the band aid your patch is providing A+
The height of the document is irrelevant. Instead, if the actual height is less than the height of the client area, the scrollbar should also be set to zero, as shown by tests included in the attached patch. Empty text is just one special case. Changelog: * Text that does not need to be scrolled should also result in a scroll range of zero * Tests for this behavior -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
Alex Villacís Lasso escribió:
Eric Pouech escribió:
Alex Villacís Lasso a écrit :
Even though the code freeze is still in effect, I post this so that it will be reviewed. For more information, see bug #12311.
Changelog: * richedit: empty text should result in a scroll range of 0. * Tests for this behavior.
------------------------------------------------------------------------
what I don't understand is why the height of an empty doc is not zero (I had similar issues with the height of a doc where we systematically get one row too much). I believe this root cause should be fixed instead of the band aid your patch is providing A+
The height of the document is irrelevant. Instead, if the actual height is less than the height of the client area, the scrollbar should also be set to zero, as shown by tests included in the attached patch. Empty text is just one special case.
Changelog: * Text that does not need to be scrolled should also result in a scroll range of zero * Tests for this behavior
The previous version resulted in a misassignment of the range when scrollbars forced visible but scroll range makes scrollbar visible. This version fixes it. Changelog: * Text that does not need to be scrolled should also result in a scroll range of zero * Tests for this behavior -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
participants (2)
-
Alex Villacís Lasso -
Eric Pouech