Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something

[Joris Huizer]

--- On Thu, 4/2/09, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> From: Nikolay Sivov <bunglehead(a)gmail.com>
> Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
> To: wine-devel(a)winehq.org, joris_huizer(a)yahoo.com
> Date: Thursday, April 2, 2009, 2:04 PM
> > Joris Huizer wrote:
> > Hi, Joris. Thanks for spotting this, but changes you've
> > made will fail on Windows. I've just sent a corrected
> > version with one test more.
> > Here it is if you're interested:
> > http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html

No problem :-)
Sorry I didn't test with Windows just as I don't have it available;
I wasn't sure what would be the proper action, to send a best-guess patch or personal email - any ideas on this in general?

regards, Joris

dlls/comctl32/tests/listview.c: fix ok statements to actually test something

[Nikolay Sivov]

Joris Huizer wrote:
> --- On Thu, 4/2/09, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> > From: Nikolay Sivov <bunglehead(a)gmail.com>
> > Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
> > To: wine-devel(a)winehq.org, joris_huizer(a)yahoo.com
> > Date: Thursday, April 2, 2009, 2:04 PM
> > > Joris Huizer wrote:
> >
> > Hi, Joris. Thanks for spotting this, but changes you've
> > made will fail on Windows. I've just sent a corrected
> > version with one test more.
> > Here it is if you're interested:
> > http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html
>
> No problem :-)
> Sorry I didn't test with Windows just as I don't have it available;
> I wasn't sure what would be the proper action, to send a best-guess patch or personal email - any ideas on this in general?
>
> regards, Joris

The best way for me is send a mail to wine-devel with commit subject 
line (cause speaking of that case wrong patch was already committed) 
that any developer could review it and send a fix. Patch author could be 
easily unavailable so personal mailing will delay a fix.
A patch to wine-patches is also acceptable of course.