[PATCH 1/3] shell32: implement IID_IContextMenu in CreateViewObject() methods for shell folders that support it
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39841 Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> --- dlls/shell32/cpanelfolder.c | 6 +-- dlls/shell32/recyclebin.c | 2 + dlls/shell32/shfldr_desktop.c | 3 +- dlls/shell32/shfldr_fs.c | 3 +- dlls/shell32/shfldr_mycomp.c | 3 +- dlls/shell32/shfldr_netplaces.c | 10 ++--- dlls/shell32/shfldr_printers.c | 5 ++- dlls/shell32/shfldr_unixfs.c | 2 + dlls/shell32/tests/shlfolder.c | 72 +++++++++++++++++++++++++++++++++ 9 files changed, 91 insertions(+), 15 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=89766 Your paranoid android. === w2008s64 (32 bit report) === shell32: shlfolder.c:4487: Test failed: got 0x80070002 shlfolder.c:4503: Test failed: got 0x80070002 shlfolder.c:4511: Test failed: got 0x80070002 shlfolder.c:4519: Test failed: got 0x80070002 === w1064v1507 (32 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 === w1064v1809 (32 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4926: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 40000) === w1064 (32 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1cdc:shlfolder: unhandled exception c0000005 at 0045DB08 === w1064_tsign (32 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1254:shlfolder: unhandled exception c0000005 at 0045DB08 === w10pro64 (32 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 0ab4:shlfolder: unhandled exception c0000005 at 0045DB08 === wvistau64 (64 bit report) === shell32: shlfolder.c:4487: Test failed: got 0x80070002 shlfolder.c:4503: Test failed: got 0x80070002 shlfolder.c:4511: Test failed: got 0x80070002 shlfolder.c:4519: Test failed: got 0x80070002 === w2008s64 (64 bit report) === shell32: shlfolder.c:4487: Test failed: got 0x80070002 shlfolder.c:4503: Test failed: got 0x80070002 shlfolder.c:4511: Test failed: got 0x80070002 shlfolder.c:4519: Test failed: got 0x80070002 === w1064v1507 (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 === w1064v1809 (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4909: Test failed: RMDIR: expected notification type 10, got: 40000 shlfolder.c:4916: Test failed: GetDisplayNameOf failed: 0x80070057 shlfolder.c:4926: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10) === w1064 (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1c58:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w1064_2qxl (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 118c:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w1064_tsign (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 100c:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w10pro64 (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 02e8:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1a8c:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w10pro64_he (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 0bf0:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1e1c:shlfolder: unhandled exception c0000005 at 00000000004536C9 === w10pro64_zh_CN (64 bit report) === shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1f14:shlfolder: unhandled exception c0000005 at 00000000004536C9
On Sun, 2 May 2021, Marvin wrote: [...]
=== w1064v1507 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002
=== w1064v1809 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4926: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 40000)
=== w1064 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1cdc:shlfolder: unhandled exception c0000005 at 0045DB08
Ouch!!! As predicted by the TestBot this patch is causing failures and crashes on a lot of Windows versions. Could you have a look? https://test.winehq.org/data/patterns.html#shell32:shlfolder -- Francois Gouget <fgouget(a)codeweavers.com>
On Tue, May 4, 2021 at 12:16 PM Francois Gouget <fgouget(a)codeweavers.com> wrote:
On Sun, 2 May 2021, Marvin wrote: [...]
=== w1064v1507 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002
=== w1064v1809 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4926: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 40000)
=== w1064 (32 bit report) ===
shell32: shlfolder.c:4495: Test failed: got 0x80004002 shlfolder.c:4501: Test failed: got 0x80040111 1cdc:shlfolder: unhandled exception c0000005 at 0045DB08
Ouch!!! As predicted by the TestBot this patch is causing failures and crashes on a lot of Windows versions. Could you have a look?
https://test.winehq.org/data/patterns.html#shell32:shlfolder
-- Francois Gouget <fgouget(a)codeweavers.com>
Sorry. https://source.winehq.org/patches/data/205146 should fix it. Damjan
participants (3)
-
Damjan Jovanovic -
Francois Gouget -
Marvin