Re: [TRY 2] [1/3] programs: initial add extrac32 utility

[Nikolay Sivov]

Ilya Shpigor wrote:
> ------------------------------------------------------------------------

Hi, Ilya.

You need to include patched configure.ac as well with new 
WINE_CONFIG_MAKEFILE entry.

[TRY 2] [1/3] programs: initial add extrac32 utility

[Ilya Shpigor]

Hi, Nikolay
> You need to include patched configure.ac as well with new
> WINE_CONFIG_MAKEFILE entry.

Are you shure what the changes in configure.ac needed?

Andrey Turkin wrote in list below:
> No you don't need to (most patches do add some subset of autogenerated 
> files for some reason but it is not necessary).

-- 
Best regards,
Ilya Shpigor.

[TRY 2] [1/3] programs: initial add extrac32 utility

[Nikolay Sivov]

Ilya Shpigor wrote:
> Hi, Nikolay
> > You need to include patched configure.ac as well with new
> > WINE_CONFIG_MAKEFILE entry.
>
> Are you shure what the changes in configure.ac needed?

Yes.
> Andrey Turkin wrote in list below:
> > No you don't need to (most patches do add some subset of autogenerated 
> > files for some reason but it is not necessary).
>
> Makefile.in and congifure.ac aren't autogenerated, but Makefile and 
> configure are. Currently Makefile is
> in ignore list, but configure isn't of course, that's why you need to 
> remove configure diff from your patch,
> but keep configure.ac in it. Alexandre will regenerate configure with 
> autoconf amyway aftret configure.ac changed.

[TRY 2] [1/3] programs: initial add extrac32 utility

[Henri Verbeet]

2009/10/22 Nikolay Sivov <bunglehead(a)gmail.com>:
> Makefile.in and congifure.ac aren't autogenerated, but Makefile and
> They're generated by tools/make_makefiles.

[TRY 2] [1/3] programs: initial add extrac32 utility

[Ilya Shpigor]

> You need to include patched configure.ac as well with new
> WINE_CONFIG_MAKEFILE entry.

Are there other troubles in these patches?

-- 
Best regards,
Ilya Shpigor.