Re: [dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c

[Vitaliy Margolen]

Christoph Frick wrote:
> diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c
> index 5f927d0..baca0b3 100644
> --- a/dlls/dinput/device.c
> +++ b/dlls/dinput/device.c
> @@ -1400,3 +1400,54 @@ HRESULT WINAPI IDirectInputDevice8WImpl_GetImageInfo(LPDIRECTINPUTDEVICE8W iface

Please don't. Device is common for everything (keyboard, mouse, joysticks). 
Joystick specific code should not be there.


Vitaliy.

[dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c

[Christoph Frick]

On Sat, Apr 26, 2008 at 08:39:19AM -0600, Vitaliy Margolen wrote:
> Christoph Frick wrote:
> > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c
> > index 5f927d0..baca0b3 100644
> > --- a/dlls/dinput/device.c
> > +++ b/dlls/dinput/device.c
> > @@ -1400,3 +1400,54 @@ HRESULT WINAPI IDirectInputDevice8WImpl_GetImageInfo(LPDIRECTINPUTDEVICE8W iface
>
> Please don't. Device is common for everything (keyboard, mouse,
> joysticks).  Joystick specific code should not be there.

i dont like it in joysticks_linuxinput. it stands there right before the
bigbig ifdef and the only reason it is there, is because it was written
for that file in the first place. any suggestions where to move it? on
the other hand my other patch does not depend on the move - just on the
functions - so we just keep in the linux file until we get the common
joystick class.

-- 
cu