Re: [PATCH] Make wine build with the Intel CC [Resent]

[Jonathan Schleifer]

For some strange reason, this mail didn't appear on the list. Therefore
I resent it. (Maybe it's missing because it included an attached GPG
signature?)


Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote:
> Wine could build fine without c++, not sure why everything has to
> link against the c++ library as it will probably only be needed in
> winegcc. Also these compiling flags seem kind of agressive.

As I said, just quoted from my .profile, nothing special for wine. I
just have -lstdc++ added there as some apps need it to compile with icc.
> They are defined in include/winbase.h

That's the point. They are defined INCLUDING the asm code. That's why
the asm code is already defined and not needed in the file itself.
> just make sure icc is recognised there.

You mean: Make sure that icc doesn't get recognized as gcc. Well,
I tried that. It doesn't work. This will still end in stuff like:
/tmp/iccCwib4Das_.s:1499: Error: symbol `wine_get_fs' is already defined
/tmp/iccCwib4Das_.s:1523: Error: symbol `wine_set_fs' is already defined
> you can't just comment out those Interlocked functions, some
> applications might need them.

I only commented them out because they are defined TWICE. They are still
there and thus the programs run. I tested running a few apps with this
patch.
> Plus the way you do it makes the code unreadable. I cannot test this
> as I don't have icc.

I'm sure someone on the list has icc.

-- 
Jonathan