Re: [PATCH] configure: Check for linker relocation support before relying on prelink

[Alexandre Julliard]

Michael Cronenworth <mike(a)cchtml.com> writes:
> @@ -1167,8 +1173,9 @@ static void build(struct options* opts)
>      spawn(opts->prefix, link_args, 0);
>      strarray_free (link_args);
>
> -    /* set the base address */
> -    if (opts->image_base && !opts->target)
> +    /* set the base address with prelink if linker support is not present */
> +    if (opts->image_base && !opts->target &&
> +        try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base)))

It looks OK now, but please avoid calling try_link() twice for the same
check.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] configure: Check for linker relocation support before relying on prelink

[Michael Cronenworth]

On 10/21/2015 02:17 AM, Alexandre Julliard wrote:
> It looks OK now, but please avoid calling try_link() twice for the same
> check.

OK, please reject this patch and I'll submit another revision. The next one will be 
prefixed with "winegcc:".

Thanks,
Michael