Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable
Aric Stewart <aric(a)codeweavers.com> writes:
--- programs/regedit/regedit.c | 2 +- programs/regedit/regproc.c | 19 +++++++++++-------- programs/regedit/regproc.h | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-)
We shouldn't need to seek at all, instead it should be easy to test the first two bytes of the first line before processing it. -- Alexandre Julliard julliard(a)winehq.org
True, through I did not add the code that was doing the seeking so i tried to not be too intrusive. Should I rework the way we do the line processing to be able to do this then? -aric Alexandre Julliard wrote:
Aric Stewart <aric(a)codeweavers.com> writes:
--- programs/regedit/regedit.c | 2 +- programs/regedit/regproc.c | 19 +++++++++++-------- programs/regedit/regproc.h | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-)
We shouldn't need to seek at all, instead it should be easy to test the first two bytes of the first line before processing it.
Aric Stewart <aric(a)codeweavers.com> writes:
True, through I did not add the code that was doing the seeking so i tried to not be too intrusive.
Should I rework the way we do the line processing to be able to do this then?
Yes please. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Aric Stewart