Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

[Jacek Caban]

On 06/26/11 18:28, Detlef Riekenberg wrote:
> How can we force tests to use VT_UI4?

It's not JScript builtin type, you need to extend tests host object for
that.
> --
> By by ... Detlef
> ---
>  dlls/jscript/tests/lang.js |   31 +++++++++++++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js
> index b54eef2..b96788b 100644
> --- a/dlls/jscript/tests/lang.js
> +++ b/dlls/jscript/tests/lang.js
> @@ -306,6 +306,37 @@ tmp = 3/2;
>  ok(tmp === 1.5, "3/2 !== 1.5");
>  ok(getVT(tmp) === "VT_R8", "getVT(3/2) !== VT_R8");
>
> +/* 0x7fffffff is 2147483647 is INT_MAX */
> +tmp = 2147483647*-1;

0x... is correct jscript syntax, why not use it?

Jacek

[PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

[Detlef Riekenberg]

On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote:
> > How can we force tests to use VT_UI4?
> > It's not JScript builtin type, you need to extend tests host object for
> > that.

Sorry, no clue.
Which host object?
> > +/* 0x7fffffff is 2147483647 is INT_MAX */
> > +tmp = 2147483647*-1;
>
> 0x... is correct jscript syntax, why not use it?

Didn't know that. Thanks for the hint


-- 
By by ... Detlef

[PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

[Jacek Caban]

On 06/28/11 15:47, Detlef Riekenberg wrote:
> On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote:
> > > How can we force tests to use VT_UI4?
> > > It's not JScript builtin type, you need to extend tests host object for
> > > that.
> > > Sorry, no clue.
> > > Which host object

Global host object for tests. See how nullDisp is done in run.c.

Jacek