Re: [PATCH 1/3] port: MSVC provides a correct getenv prototype.

[Stefan Dösinger]

Am 19.12.2013 um 15:23 schrieb Jonas Maebe <jonas.maebe(a)elis.ugent.be>:
> Shouldn't the title of this patch read "getopt" instead of "getenv"?
> Uh, now that you mention it, the title isn’t quite right. It should be more like "port: MSVC does not provide a conflicting getopt prototype." - It doesn’t provide a getopt prototype at all.

The stdlib.h include is needed for getenv, which is used in the file. I misread the "getopt" in the comment as "getenv" on my quick read. (And yes, I did wonder how this code is supposed to work without defining getenv at all, but my conclusion was that maybe a warning about undefined getenv was considered better than a compile error. It makes a lot more sense with a conflicting getopt.)

I took the liberty to CC wine-devel on my reply.