Re: [PATCH 5/5] ddraw/tests: Remove p8_primary_test.

[Henri Verbeet]

On 5 June 2016 at 20:45, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> Other than being in the old place, this test doesn't initialize Surface1
> and randomly crashes when SetDisplayMode fails.
> ---
> That's likely all true, but those would be reasons for fixing the test
> instead of removing it. Do the previous two tests in the series cover
> all the functionality tested by this test?

[PATCH 5/5] ddraw/tests: Remove p8_primary_test.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-06-07 um 16:18 schrieb Henri Verbeet:
> That's likely all true, but those would be reasons for fixing the
> test instead of removing it. Do the previous two tests in the
> series cover all the functionality tested by this test?
> In the past you rejected even typo fixes in the old files :-) .

Covering the functionality in the new tests was the intention, yeah.
The color table verification already exists in test_palette_gdi. The
two patches add the GetDC color verification and Blitting tests,
although they test the blit result through locking the surface instead
of reading it through GetDC. Because the DIB is and always has been
based on the P8 data this doesn't make a difference.

I didn't take the lock - blit - lock - blit test along because we have
many other tests that check our texture upload and download codepaths.
Since we're doing P8 conversion only when showing the final front
buffer P8 transfers aren't special in that regard any more.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXVyOfAAoJEN0/YqbEcdMw5zAP/3jZcvduiDL9mx2jTCmJ0L2f
bAGzXcr+doX21L78Wrz3pByZYuVLFLNAxiR5wNJp9GPh0GEDdLH6hJmtDoXArM9d
5EhNYiaDjoqow6B4qoTBC3jYzattgrClp9pQ/4prix3i5FX4/CEfx29XzaVdXQPS
EIP6mlrrPiR8NVbSY+MCcs78Wt5IXwdi9b4XVRhjryyzEzgRAEaJhJ0cJwMQslzM
xMsPwjhZV5ExFTKBjw+fOcfqUZZewR+LIno6Prahaxo7XN8NXU0xp8+o24dVSvgX
zictrMqmYx90RW4N/kFVjd30Frz3wB/dOXQlKeSez+frn/JLwZ8FePdT++jy/9wK
dLXsLNl9J73bIrhZczjs+YKjR9+NETbtSvjZ/LyHXm9oaG4f7WvW/5NaQ4yiOo7b
8snb9v4ICJ00pRF80cpLjLJ/kAYp6wENEY5crMvolLAnDvobaoaTLXBdJwrWpPTW
HqvmvvSfOjLzhHOf58QsCWg7Nk7SqPrOAx7XkscHXbaZRMY9DcgouH8I3zjkUQvn
cuX0x1lmwapmtcsu9OqlW/YkHpCpH5CY49hDdxahI84aMicmFERRDdHq5fYxcNKQ
BP6EsNdD1yi3cyir/hG0a4Yz7hOFrIMHgucuRUk3RCbyjDPy0yqdlH0NSYVBV+wI
q/tg0GTqKYw7HIdvfQH6
=loqo
-----END PGP SIGNATURE-----

[PATCH 5/5] ddraw/tests: Remove p8_primary_test.

[Henri Verbeet]

On 7 June 2016 at 21:42, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> Am 2016-06-07 um 16:18 schrieb Henri Verbeet:
> > That's likely all true, but those would be reasons for fixing the
> > test instead of removing it. Do the previous two tests in the
> > series cover all the functionality tested by this test?
> > In the past you rejected even typo fixes in the old files :-) .

Well, yeah, fixing it would involve rewriting it for ddraw[1247].c.