Re: Small DSound fix...

[Christian Costa]

Lionel Ulmer wrote:
> Hi all,
>
> This makes games which do NOT enumerate the sound devices and go through the
> ClassFactory work.
>
> It has also some miscellaneous tracing fixes.
>
> Changelog:
> - misc. tracing fixes
> - handle IID_IDirectSound(8) as the default sound driver

A ce que je vois ton patch remplace le mien (qui n'a pas ete accepte 
d'ailleurs)...

P'tite curiosite.. :-) :
Mais qu'est ce que ces foutues IIDs viennent faire a la place des GUID 
des devices ?
C'est une bidouille ou bien DirectSoundCreate les acceptent vraiment ?


Christian

Small DSound fix...

[Vincent Béron]

Christian Costa a écrit:
> Lionel Ulmer wrote:
> > Hi all,
> >
> > This makes games which do NOT enumerate the sound devices and go 
> > through the
> > ClassFactory work.
> >
> > It has also some miscellaneous tracing fixes.
> >
> > Changelog:
> > - misc. tracing fixes
> > - handle IID_IDirectSound(8) as the default sound driver
>
> A ce que je vois ton patch remplace le mien (qui n'a pas ete accepte 
> d'ailleurs)...
>
> P'tite curiosite.. :-) :
> Mais qu'est ce que ces foutues IIDs viennent faire a la place des GUID 
> des devices ?
> C'est une bidouille ou bien DirectSoundCreate les acceptent vraiment ?

Envoyé en français par erreur à la liste probablement Christian? :)

Whole translation for non-french speaking people here:

I see that your patch replaces mine (which hasn't been accepted yet)...

Out of curiosity... :-) :
What all those bloody IIDs do instead of devices' GUID?
Is it a gimmick or does DirectSoundCreate really accepts them?

(me)
Sent to the list by mistake in French Christian? :)

Vincent

Small DSound fix...

[Christian Costa]

Vincent Béron wrote:
> Christian Costa a écrit:
> > Lionel Ulmer wrote:
> > > Hi all,
> > >
> > > This makes games which do NOT enumerate the sound devices and go 
> > > through the
> > > ClassFactory work.
> > >
> > > It has also some miscellaneous tracing fixes.
> > >
> > > Changelog:
> > > - misc. tracing fixes
> > > - handle IID_IDirectSound(8) as the default sound driver
> >
> > A ce que je vois ton patch remplace le mien (qui n'a pas ete accepte 
> > d'ailleurs)...
> >
> > P'tite curiosite.. :-) :
> > Mais qu'est ce que ces foutues IIDs viennent faire a la place des 
> > GUID des devices ?
> > C'est une bidouille ou bien DirectSoundCreate les acceptent vraiment ?
>
> Envoyé en français par erreur à la liste probablement Christian? :)
>
> Whole translation for non-french speaking people here:
>
> I see that your patch replaces mine (which hasn't been accepted yet)...
>
> Out of curiosity... :-) :
> What all those bloody IIDs do instead of devices' GUID?
> Is it a gimmick or does DirectSoundCreate really accepts them?
>
> (me)
> Sent to the list by mistake in French Christian? :)
>
> Vincent

Arghhh! I should better go to sleep! Really sorry... :-(
But well! Thanks for the translation though. :-)

Christian

Small DSound fix...

[Robert Reif]

This patch is all wrong.  It makes no sense to pass a
software class id to a function that only accepts hardware ids.
The real bug is in the class factory. 0 should be passed rather
than the class id.  Look at the capture part a few lines below it.
Passing 0 or NULL will select the default device.

I can't generate a patch now but the trivial fix is to pass 0 rather
than the class id in the class factory.

Bob.

Small DSound fix...

[Lionel Ulmer]

Replying in English :-)
> A ce que je vois ton patch remplace le mien (qui n'a pas ete accepte 
> d'ailleurs)...

Did not remember that you submitted a patch for this... Was only aware of
the DInput one for ClassFactory, not the one on DSound.
> P'tite curiosite.. :-) :
> Mais qu'est ce que ces foutues IIDs viennent faire a la place des GUID 
> des devices ?
> C'est une bidouille ou bien DirectSoundCreate les acceptent vraiment ?
> From what I know, it's about the same as out 'fake' GUIDs we have for
> DirectX. Ie each driver has its own GUID so that a game can specifically ask
> for one device (and when a game asks Wine to enumerate the DSound devices,
> these 'fake' devices are actually returned => it works fine there).

The problem is for games expecting the default driver being returned when
using the 'generic' GUID (ie without doing an enumeration and without using
the DefaultPlayback GUID).

                      Lionel

-- 
		 Lionel Ulmer - http://www.bbrox.org/

Small DSound fix...

[Christian Costa]

Lionel Ulmer wrote:
> Replying in English :-)
> > A ce que je vois ton patch remplace le mien (qui n'a pas ete accepte 
> > d'ailleurs)...
>
> Did not remember that you submitted a patch for this... Was only aware of
> the DInput one for ClassFactory, not the one on DSound.

You're completely right!
I check into my mail box and realized I sent a patch with the title
"[DSOUND] Fix argument passed to DirectSoundCreate8"
just after the dinput's one but I attached the dinput diff a second time 
instead!!!
No one noticed... Not even me... Arghhh!
> > P'tite curiosite.. :-) :
> > Mais qu'est ce que ces foutues IIDs viennent faire a la place des GUID 
> > des devices ?
> > C'est une bidouille ou bien DirectSoundCreate les acceptent vraiment ?
> > From what I know, it's about the same as out 'fake' GUIDs we have for
> > DirectX. Ie each driver has its own GUID so that a game can specifically ask
> > for one device (and when a game asks Wine to enumerate the DSound devices,
> > these 'fake' devices are actually returned => it works fine there).
>
> The problem is for games expecting the default driver being returned when
> using the 'generic' GUID (ie without doing an enumeration and without using
> the DefaultPlayback GUID).
>
> Lionel