Re: version resource for regsvr32

[Dmitry Timoshkov]

"Stefan Leichter" <Stefan.Leichter(a)camLine.com> wrote:
> ChangeLog
> --------------
>         added version info resource to regsvr32

It's too late since Alxandre has committed the patch, but
it's worth to mention that it's better to use a common
pattern for creating version resources for Wine DLLSs,
which uses wine/wine_common_ver.rc.

Could you send a new patch for that?

-- 
Dmitry.

version resource for regsvr32

[Stefan Leichter]

Am Samstag, 29. November 2003 04:12 schrieb Dmitry Timoshkov:
> "Stefan Leichter" <Stefan.Leichter(a)camLine.com> wrote:
> > ChangeLog
> > --------------
> >         added version info resource to regsvr32
>
> It's too late since Alxandre has committed the patch, but
> it's worth to mention that it's better to use a common
> pattern for creating version resources for Wine DLLSs,
> which uses wine/wine_common_ver.rc.
>
> Could you send a new patch for that?

looks like i have used one of the four place as example where it is done in a 
different way

ChangeLog
--------------
	changed the version resource to be create in  the common way

version resource for regsvr32

[Dimitrie O. Paun]

On November 29, 2003 04:54 am, Stefan Leichter wrote:
> looks like i have used one of the four place as example where it is done in
> a different way

Maybe the other places need to be changed as well?

-- 
Dimi.

version resource for regsvr32

[Alexandre Julliard]

"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes:
> It's too late since Alxandre has committed the patch, but
> it's worth to mention that it's better to use a common
> pattern for creating version resources for Wine DLLSs,
> which uses wine/wine_common_ver.rc.

Currently wine_common_ver.rc sets the file type to dll, so it's not
really appropriate for programs. We'll probably need to add another
define for that.

-- 
Alexandre Julliard
julliard(a)winehq.com