Re: RSAENH_CPGetProvParam

[Alexandre Julliard]

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes:
> +        case PP_KEYSTORAGE:
> +            dwTemp = GetVersion();
> +            /* for Windows NT, 95,98, Me, return CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR
> +             * for the others, return CRYPT_SEC_DESCR
> +             */
> +            if(dwTemp < 0x80000000 && ((dwTemp & 0x000000FF)  != 0x00000004))
> +                dwTemp = CRYPT_SEC_DESCR;
> +            else
> +                dwTemp = CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR;

You shouldn't add such version checks, unless you have a real life app
that depends on the difference.

-- 
Alexandre Julliard
julliard(a)winehq.org

RSAENH_CPGetProvParam

[Mounir IDRASSI]

Actually, the only application I know that uses this expects only
CRYPT_SEC_DESCR. So, as you advised, I'll rewrite the patch to remove
the version check.

Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr

Alexandre Julliard wrote:
> Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes:
> > +        case PP_KEYSTORAGE:
> > +            dwTemp = GetVersion();
> > +            /* for Windows NT, 95,98, Me, return CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR
> > +             * for the others, return CRYPT_SEC_DESCR
> > +             */
> > +            if(dwTemp < 0x80000000 && ((dwTemp & 0x000000FF)  != 0x00000004))
> > +                dwTemp = CRYPT_SEC_DESCR;
> > +            else
> > +                dwTemp = CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR;
>
> You shouldn't add such version checks, unless you have a real life app
> that depends on the difference.