Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

[Austin English]

On Wed, Jul 18, 2012 at 6:33 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> Without this patch, Internet Explorer 6 produces a lot of messages like
> "fixme:wininet:InternetCanonicalizeUrlW Unhandled flags 0x04000000"
>
> Wine's wininet.h was missing ICU_ENCODE_PERCENT, which is present in
> the wininet.h from the Windows 7 SDK.
>
> Wine previously treated ICU_ESCAPE like ICU_DECODE. This is incorrect,
> MSDN and empirical tests agree that ICU_ESCAPE should be ignored:
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa384342(v=vs.85).as...
> https://testbot.winehq.org/JobDetails.pl?Key=20155

Why didn't you include the tests in the patch?

-- 
-Austin

wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

[Alex Henrie]

2012/7/19 Austin English <austinenglish(a)gmail.com>:
> Why didn't you include the tests in the patch?

The "tests" I wrote always fail in order to output the result of the
function to the console for comparison by hand. ICU_ESCAPE is clearly
not meant to be used with InternetCanonicalizeUrl, so I'm not sure a
test for it is necessary. That said, if you would like me to include a
few tests in the patch, let me know.

-Alex

wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

[Austin English]

On Thu, Jul 19, 2012 at 7:23 AM, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> 2012/7/19 Austin English <austinenglish(a)gmail.com>:
> > Why didn't you include the tests in the patch?
>
> The "tests" I wrote always fail in order to output the result of the
> function to the console for comparison by hand. ICU_ESCAPE is clearly
> not meant to be used with InternetCanonicalizeUrl, so I'm not sure a
> test for it is necessary. That said, if you would like me to include a
> few tests in the patch, let me know.

You can set WINETEST_VERBOSE=1 to get the output, whether is passes or
fails. Simply changing FALSE to TRUE shows all the tests pass, though
you'd likely want to test some broken behavior as well.

Of course, it's up to Alexandre if he wants to accept it without
tests. I was mostly curious why you didn't submit them, since you
already took the effort to write them :).

-- 
-Austin