Re: kernel32: add more tests for FormatMessage{A,W}
27 Oct
2009
27 Oct
'09
2:24 a.m.
"Louis Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote:
The attached tests show that this is true for "non-special" language-id's, but not for the special ones: (LANG_NEUTRAL, SUBLANG_NEUTRAL), (LANG_NEUTRAL, SUBLANG_DEFAULT),(LANG_NEUTRAL, SUBLANG_SYS_DEFAULT), and (DWORD)MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)
In the latter case the error is set to ERROR_MR_MID_NOT_FOUND
A couple of suggestions: 1. There is no point in testing last error if an API didn't fail 2. It would be helpful to simultaneously test return values and last error for FindResource, which should have similar behaviour (and the bug) to FormatMessage, and drop FormatMessageW tests. -- Dmitry.
5893
Age (days ago)
5893
Last active (days ago)
0 comments
1 participants
participants (1)
-
Dmitry Timoshkov