Re: [PATCH] wined3d: Ignore clears if count = 0 and rects != NULL
On 23 January 2013 13:14, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
dlls/d3d8/tests/visual.c | 17 +++++++++++++++++ dlls/d3d9/tests/visual.c | 16 ++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 36 ++++++++++++++++++++++++++++++++++++ dlls/wined3d/device.c | 6 ++++++ 4 files changed, 75 insertions(+)
Although I don't expect a difference in behaviour, it probably wouldn't hurt to add tests for the other ddraw versions as well (i.e. through the viewport interface).
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-01-23 13:28, schrieb Henri Verbeet:
Although I don't expect a difference in behaviour, it probably wouldn't hurt to add tests for the other ddraw versions as well (i.e. through the viewport interface). I was under the assumption that we already had a test for that - those interfaces expect both count and rectangle to be non-zero, otherwise they return an error.
I can't find the test right now, so it seems that assumption was wrong. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJQ/9lpAAoJEN0/YqbEcdMwnFwP/RzV2jNv/IJCNP7VmViBvIwv m9irM59PbgWzIyxsjrGaogwpDuyok75yg+itpmEsQYBi7iMKem6vwQH1iUR2qb/O SMXylcp29K0IphYMUIbd/CQSEeSsGL+00t4FpRQhqdWi2PN8Vuw6ODXKwFPnbGyI VN4BaTv8gTJyCv+CNg6Li0/u+ueu5Ut/uZo+weKTS0hMyuKx7sUxypsETNHsdltb uq/1fEWhm8Z/NQvUftQ4DlykjmxLr64OHg5lTeyKIWPti+q1VT+mBWGG6jr2Kv9e 61G70jGVCwUJa40MFDQaBJ90EuihFT5jKrl+j/J5ujNAoqUZr7QQsiBy4M2/HvYJ BQg+hN9A199RpHNOmtBG/6XTiNDj57o1CF6LQ9GmikFNbmhKHVbxoQf5yRGay98y aahejLoj14B3xH91SsvmzVyiIFQ5NBqYFunveVE1Uc79vCHUixHindHgZnfJgHqs 1mSE8sTBVgxDk8OHueZODEBkaR6Yj9EAiMK4ogKaZ5estNpm7nKs2VivFUmGvgyP Kk/mgDAr320eTaHjRcOfSnommJN54PWZ9i8kCulOh0KRLxcuoEA7YACm9fjz0wCD tYFcydlCyp2DyyhYvVmHsIgAI9MyZqxowlyK4w8b3b30QpHUQIKsaL7IQmZMeWBR VBgOn9UAWAhYA8cJXkX2 =6ijd -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-01-23 13:36, schrieb Stefan Dsinger:
I was under the assumption that we already had a test for that - those interfaces expect both count and rectangle to be non-zero, otherwise they return an error.
I can't find the test right now, so it seems that assumption was wrong. Found them on my pile of half-finished viewport tests I postponed for Wine 1.4... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJQ/94pAAoJEN0/YqbEcdMwBpgP/3J3wOqPxvpBFH6t4JHzs+8N yBNdyeePXz2P7q0QqGexC4jpfRZPPesCYaZTYKfL1pDNDmU2qHAGQym83cF269BG KV3t0cytuIqL0aXvxDNHIYkMZQJ1WYg2qRR9FyPWZ6s/GDu94CfsoUavUoIRkPsu PxSbIiRvce7qNOYViZNYpJ214d0ETAEdsFAMdpdCL988AlF/tjRIxa5XG3Gi9xxu H5z8PfNOJup+ce3r2KpVCNkRUiucSY3/dsRnCBqeRqNCT9eLFfbZm/x1zNJkqJef JFYXTV7c/+mgkDfg3HpqcbvLFX7IOPbGsYzdiYBSfJfbfUtEl2592CbqJzqBmbiY WSlPBFHZQFahq1R3G803raZnQhrRr8clU7+upRNmazv+BUlui8l11HhepSBYvTHH qzeavwGZnWuYo/m+XO13xzXfOc6E4/GjiedMsHFcjoDnWy6jiELgECQdkcg3Gki5 EiTTmJWqlFBN+0h03jWGp5ZlZCK1YhIZxjiMIIjABX2oHXuYVjWQ6ppKetuoNJa3 r/RKIp/wZbP0xaAv2FMuTX09F8dJmTzaYD4fdR8Ad1XugF1IgE00c+xloFSRGzHR IXoqCyuB19a0V7hsCR4i1jWZmHrsnEIdDrmcL6L2btarKfVaeucOwh/oQ7/A7Y/1 WXfkRMmN7BUxarT1e/XJ =97Ov -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger