Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

[Alexandre Julliard]

Christian Costa <titan.costa(a)gmail.com> writes:
> With this patch I get exactly the same output for ports caps (except guid) as native.
> I kept the comment regarding dmusic32 usage altough the native version
> of dmusic I used does standard winmm calls to get port informations.
> ---
>  dlls/dmusic/Makefile.in |    2 -
>  dlls/dmusic/dmusic.c    |  120 ++++++++++++++++++++++++++++++++---------------
>  2 files changed, 82 insertions(+), 40 deletions(-)

It doesn't work here:

../../../tools/runtest -q -P wine -M dmime.dll -T ../../.. -p dmime_test.exe.so performance.c && touch performance.ok
performance.c:111: Test failed: Got unexpected portcaps struct size: 00000004
make[1]: *** [performance.ok] Error 1

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

[Christian Costa]

Le 29/03/2012 20:25, Alexandre Julliard a écrit :
> Christian Costa<titan.costa(a)gmail.com>  writes:
> > With this patch I get exactly the same output for ports caps (except guid) as native.
> > I kept the comment regarding dmusic32 usage altough the native version
> > of dmusic I used does standard winmm calls to get port informations.
> > ---
> >   dlls/dmusic/Makefile.in |    2 -
> >   dlls/dmusic/dmusic.c    |  120 ++++++++++++++++++++++++++++++++---------------
> >   2 files changed, 82 insertions(+), 40 deletions(-)
> > It doesn't work here:
>
> ../../../tools/runtest -q -P wine -M dmime.dll -T ../../.. -p dmime_test.exe.so performance.c&&  touch performance.ok
> performance.c:111: Test failed: Got unexpected portcaps struct size: 00000004
> make[1]: *** [performance.ok] Error 1

This happens in tests newly added by Andrew (dmusic: Support creating 
default ports with GUID_NULL).
In his test, the dwSize member of the structure DMUS_PORTCAPS is not 
initialized before getting port caps
This worked because before my patch only the Microsoft Synthetizer is 
enumerated and caps returned by the Synth GepCaps
sets the dwSize member.
I can sets the dwSize in my code but normally it's up to the caller to 
set the dwSize member. The callee should copy the number
of bytes specified by dwSize or just return an error.